UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

[SCSI] pmcraid: fix to avoid twice scsi_dma_unmap for a command 

For a particular driver error condition, driver was doing double
scsi_dma_unmaps. Driver was calling scsi_dma_unmap in
pmcraid_error_handler and return 0. This pmcraid_error_handler is called
by pmcraid_io_done which will do scsi_dma_unmap again when it has
return 0 from pmcraid_error_handler.

Signed-off-by: James Bottomley <James.Bottomley@suse.de>
This commit is contained in:
Anil Ravindranath 2009-12-17 14:51:53 -08:00 committed by James Bottomley
parent 3b9c212a5c
commit a70757ba9a
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/scsi/pmcraid.c
View File

@ -2483,14 +2483,12 @@ static int pmcraid_error_handler(struct pmcraid_cmd *cmd)
sense_copied = 1; sense_copied = 1;
} }
if (RES_IS_GSCSI(res->cfg_entry)) { if (RES_IS_GSCSI(res->cfg_entry))
pmcraid_cancel_all(cmd, sense_copied); pmcraid_cancel_all(cmd, sense_copied);
} else if (sense_copied) { else if (sense_copied)
pmcraid_erp_done(cmd); pmcraid_erp_done(cmd);
return 0; else
} else {
pmcraid_request_sense(cmd); pmcraid_request_sense(cmd);
}
return 1; return 1;