UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

objtool: Remove redundant checks on operand type 

POP operations are already in the code path where the destination
operand is OP_DEST_REG. There is no need to check the operand type
again.

Signed-off-by: Julien Thierry <jthierry@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Julien Thierry 2020-03-27 15:28:39 +00:00 committed by Ingo Molnar
parent aa5847270a
commit a70266b5b2
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/objtool/check.c
View File

@ -1715,15 +1715,13 @@ static int update_insn_state(struct instruction *insn, struct insn_state *state)
case OP_SRC_POP: case OP_SRC_POP:
case OP_SRC_POPF: case OP_SRC_POPF:
if (!state->drap && op->dest.type == OP_DEST_REG && if (!state->drap && op->dest.reg == cfa->base) {
op->dest.reg == cfa->base) {
/* pop %rbp */ /* pop %rbp */
cfa->base = CFI_SP; cfa->base = CFI_SP;
} }
if (state->drap && cfa->base == CFI_BP_INDIRECT && if (state->drap && cfa->base == CFI_BP_INDIRECT &&
op->dest.type == OP_DEST_REG &&
op->dest.reg == state->drap_reg && op->dest.reg == state->drap_reg &&
state->drap_offset == -state->stack_size) { state->drap_offset == -state->stack_size) {