UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

crypto: ccp - Fix a resource leak in an error handling path 

If an error occurs after calling 'sp_get_irqs()', 'sp_free_irqs()' must be
called as already done in the error handling path.

Fixes: f4d18d656f ("crypto: ccp - Abstract interrupt registeration")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: John Allen <john.allen@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Christophe JAILLET 2021-05-16 08:58:04 +02:00 committed by Herbert Xu
parent b7da13d092
commit a6f8e68e23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/crypto/ccp/sp-pci.c
View File

@ -222,7 +222,7 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
if (ret) { if (ret) {
dev_err(dev, "dma_set_mask_and_coherent failed (%d)\n", dev_err(dev, "dma_set_mask_and_coherent failed (%d)\n",
ret); ret);
goto e_err; goto free_irqs;
} }
} }
@ -230,10 +230,12 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
ret = sp_init(sp); ret = sp_init(sp);
if (ret) if (ret)
goto e_err; goto free_irqs;
return 0; return 0;
free_irqs:
sp_free_irqs(sp);
e_err: e_err:
dev_notice(dev, "initialization failed\n"); dev_notice(dev, "initialization failed\n");
return ret; return ret;