UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

ASoC: mediatek: mt8173: Fix snd_soc_component_initialize error path 

If the second component fails to initialize, cleanup the first on.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: stable@kernel.org
Fixes: f1b5bf0736 ("ASoC: mt2701/mt8173: replace platform to component")
Signed-off-by: Ricardo Ribalda Delgado <ribalda@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230612-mt8173-fixup-v2-1-432aa99ce24d@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Ricardo Ribalda Delgado 2023-06-12 11:05:31 +02:00 committed by Mark Brown
parent 62a97bea5c
commit a46d37012a
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
View File

@ -1156,14 +1156,14 @@ static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev)
comp_hdmi = devm_kzalloc(&pdev->dev, sizeof(*comp_hdmi), GFP_KERNEL); comp_hdmi = devm_kzalloc(&pdev->dev, sizeof(*comp_hdmi), GFP_KERNEL);
if (!comp_hdmi) { if (!comp_hdmi) {
ret = -ENOMEM; ret = -ENOMEM;
goto err_pm_disable; goto err_cleanup_components;
} }
ret = snd_soc_component_initialize(comp_hdmi, ret = snd_soc_component_initialize(comp_hdmi,
&mt8173_afe_hdmi_dai_component, &mt8173_afe_hdmi_dai_component,
&pdev->dev); &pdev->dev);
if (ret) if (ret)
goto err_pm_disable; goto err_cleanup_components;
#ifdef CONFIG_DEBUG_FS #ifdef CONFIG_DEBUG_FS
comp_hdmi->debugfs_prefix = "hdmi"; comp_hdmi->debugfs_prefix = "hdmi";