lib/bch.c: replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension
to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning in
case the flexible array does not occur last in the structure, which will
help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293
("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20200211205119.GA21234@embeddedor
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
aecd42df6d
commit
a44ce51370
|
@ -102,7 +102,7 @@
|
||||||
*/
|
*/
|
||||||
struct gf_poly {
|
struct gf_poly {
|
||||||
unsigned int deg; /* polynomial degree */
|
unsigned int deg; /* polynomial degree */
|
||||||
unsigned int c[0]; /* polynomial terms */
|
unsigned int c[]; /* polynomial terms */
|
||||||
};
|
};
|
||||||
|
|
||||||
/* given its degree, compute a polynomial size in bytes */
|
/* given its degree, compute a polynomial size in bytes */
|
||||||
|
|
Loading…
Reference in New Issue