UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

iio: adc: cc10001: Use devm_ to call device power down. 

It is presumably safe to call the powerdown whether or not we are
in the commented shared state (the driver always did this).

The power down was previously out of order wrt to the probe() function
so move using devm_ will ensure it occurs after the userspace interfaces
are removed.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20221016170950.387751-5-jic23@kernel.org
This commit is contained in:
Jonathan Cameron 2022-10-16 18:09:49 +01:00
parent c247e0d8c0
commit a43d5155b9
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/iio/adc/cc10001_adc.c
View File

@ -310,6 +310,11 @@ static void cc10001_reg_disable(void *priv)
regulator_disable(priv);
}
static void cc10001_pd_cb(void *priv)
{
cc10001_adc_power_down(priv);
}
static int cc10001_adc_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@ -375,6 +380,9 @@ static int cc10001_adc_probe(struct platform_device *pdev)
if (adc_dev->shared)
cc10001_adc_power_up(adc_dev);
ret = devm_add_action_or_reset(dev, cc10001_pd_cb, adc_dev);
if (ret)
return ret;
/* Setup the ADC channels available on the device */
ret = cc10001_adc_channel_init(indio_dev, channel_map);
if (ret < 0)
@ -405,7 +413,6 @@ static int cc10001_adc_remove(struct platform_device *pdev)
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
struct cc10001_adc_device *adc_dev = iio_priv(indio_dev);
cc10001_adc_power_down(adc_dev);
iio_device_unregister(indio_dev);
iio_triggered_buffer_cleanup(indio_dev);