UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm/ssd130x: Make ssd130x_remove() return void 

This function returns zero unconditionally, so there isn't any benefit
of returning a value. Make it return void to be able to see at a glance
that the return value of ssd130x_i2c_remove() is always zero.

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220425192306.59800-1-u.kleine-koenig@pengutronix.de
This commit is contained in:
Uwe Kleine-König 2022-04-25 21:23:06 +02:00 committed by Javier Martinez Canillas
parent 57e6f0562c
commit a4359b4e47
No known key found for this signature in database
GPG Key ID: C751E590D63F3D69
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/solomon/ssd130x-i2c.c
View File

@ -43,7 +43,9 @@ static int ssd130x_i2c_remove(struct i2c_client *client)
{
struct ssd130x_device *ssd130x = i2c_get_clientdata(client);
return ssd130x_remove(ssd130x);
ssd130x_remove(ssd130x);
return 0;
}
static void ssd130x_i2c_shutdown(struct i2c_client *client)

4
drivers/gpu/drm/solomon/ssd130x.c
View File

@ -924,11 +924,9 @@ struct ssd130x_device *ssd130x_probe(struct device *dev, struct regmap *regmap)
}
EXPORT_SYMBOL_GPL(ssd130x_probe);
int ssd130x_remove(struct ssd130x_device *ssd130x)
void ssd130x_remove(struct ssd130x_device *ssd130x)
{
drm_dev_unplug(&ssd130x->drm);
return 0;
}
EXPORT_SYMBOL_GPL(ssd130x_remove);

2
drivers/gpu/drm/solomon/ssd130x.h
View File

@ -86,7 +86,7 @@ struct ssd130x_device {
extern const struct ssd130x_deviceinfo ssd130x_variants[];
struct ssd130x_device *ssd130x_probe(struct device *dev, struct regmap *regmap);
int ssd130x_remove(struct ssd130x_device *ssd130x);
void ssd130x_remove(struct ssd130x_device *ssd130x);
void ssd130x_shutdown(struct ssd130x_device *ssd130x);
#endif /* __SSD1307X_H__ */