rt2x00: Fix rfkill polling prior to interface start.
We need to program the rfkill switch GPIO pin direction to input at device initialization time, not only when the interface is brought up. Doing this only when the interface is brought up could lead to rfkill detecting the switch is turned on erroneously and inability to create the interface and bringing it up. Reported-and-tested-by: Andreas Messer <andi@bastelmap.de> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com> Cc: <stable@vger.kernel.org> Acked-by: Ivo Van Doorn <ivdoorn@gmail.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
parent
6ced58a5db
commit
a396e10019
|
@ -1611,6 +1611,7 @@ static int rt2400pci_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
|
|||
static int rt2400pci_probe_hw(struct rt2x00_dev *rt2x00dev)
|
||||
{
|
||||
int retval;
|
||||
u32 reg;
|
||||
|
||||
/*
|
||||
* Allocate eeprom data.
|
||||
|
@ -1623,6 +1624,14 @@ static int rt2400pci_probe_hw(struct rt2x00_dev *rt2x00dev)
|
|||
if (retval)
|
||||
return retval;
|
||||
|
||||
/*
|
||||
* Enable rfkill polling by setting GPIO direction of the
|
||||
* rfkill switch GPIO pin correctly.
|
||||
*/
|
||||
rt2x00pci_register_read(rt2x00dev, GPIOCSR, ®);
|
||||
rt2x00_set_field32(®, GPIOCSR_BIT8, 1);
|
||||
rt2x00pci_register_write(rt2x00dev, GPIOCSR, reg);
|
||||
|
||||
/*
|
||||
* Initialize hw specifications.
|
||||
*/
|
||||
|
|
|
@ -670,6 +670,7 @@
|
|||
#define GPIOCSR_BIT5 FIELD32(0x00000020)
|
||||
#define GPIOCSR_BIT6 FIELD32(0x00000040)
|
||||
#define GPIOCSR_BIT7 FIELD32(0x00000080)
|
||||
#define GPIOCSR_BIT8 FIELD32(0x00000100)
|
||||
|
||||
/*
|
||||
* BBPPCSR: BBP Pin control register.
|
||||
|
|
|
@ -1929,6 +1929,7 @@ static int rt2500pci_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
|
|||
static int rt2500pci_probe_hw(struct rt2x00_dev *rt2x00dev)
|
||||
{
|
||||
int retval;
|
||||
u32 reg;
|
||||
|
||||
/*
|
||||
* Allocate eeprom data.
|
||||
|
@ -1941,6 +1942,14 @@ static int rt2500pci_probe_hw(struct rt2x00_dev *rt2x00dev)
|
|||
if (retval)
|
||||
return retval;
|
||||
|
||||
/*
|
||||
* Enable rfkill polling by setting GPIO direction of the
|
||||
* rfkill switch GPIO pin correctly.
|
||||
*/
|
||||
rt2x00pci_register_read(rt2x00dev, GPIOCSR, ®);
|
||||
rt2x00_set_field32(®, GPIOCSR_DIR0, 1);
|
||||
rt2x00pci_register_write(rt2x00dev, GPIOCSR, reg);
|
||||
|
||||
/*
|
||||
* Initialize hw specifications.
|
||||
*/
|
||||
|
|
|
@ -1768,6 +1768,7 @@ static int rt2500usb_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
|
|||
static int rt2500usb_probe_hw(struct rt2x00_dev *rt2x00dev)
|
||||
{
|
||||
int retval;
|
||||
u16 reg;
|
||||
|
||||
/*
|
||||
* Allocate eeprom data.
|
||||
|
@ -1780,6 +1781,14 @@ static int rt2500usb_probe_hw(struct rt2x00_dev *rt2x00dev)
|
|||
if (retval)
|
||||
return retval;
|
||||
|
||||
/*
|
||||
* Enable rfkill polling by setting GPIO direction of the
|
||||
* rfkill switch GPIO pin correctly.
|
||||
*/
|
||||
rt2500usb_register_read(rt2x00dev, MAC_CSR19, ®);
|
||||
rt2x00_set_field16(®, MAC_CSR19_BIT8, 0);
|
||||
rt2500usb_register_write(rt2x00dev, MAC_CSR19, reg);
|
||||
|
||||
/*
|
||||
* Initialize hw specifications.
|
||||
*/
|
||||
|
|
|
@ -197,6 +197,7 @@
|
|||
#define MAC_CSR19_BIT5 FIELD16(0x0020)
|
||||
#define MAC_CSR19_BIT6 FIELD16(0x0040)
|
||||
#define MAC_CSR19_BIT7 FIELD16(0x0080)
|
||||
#define MAC_CSR19_BIT8 FIELD16(0x0100)
|
||||
|
||||
/*
|
||||
* MAC_CSR20: LED control register.
|
||||
|
|
|
@ -983,6 +983,7 @@ static int rt2800pci_validate_eeprom(struct rt2x00_dev *rt2x00dev)
|
|||
static int rt2800pci_probe_hw(struct rt2x00_dev *rt2x00dev)
|
||||
{
|
||||
int retval;
|
||||
u32 reg;
|
||||
|
||||
/*
|
||||
* Allocate eeprom data.
|
||||
|
@ -995,6 +996,14 @@ static int rt2800pci_probe_hw(struct rt2x00_dev *rt2x00dev)
|
|||
if (retval)
|
||||
return retval;
|
||||
|
||||
/*
|
||||
* Enable rfkill polling by setting GPIO direction of the
|
||||
* rfkill switch GPIO pin correctly.
|
||||
*/
|
||||
rt2x00pci_register_read(rt2x00dev, GPIO_CTRL_CFG, ®);
|
||||
rt2x00_set_field32(®, GPIO_CTRL_CFG_GPIOD_BIT2, 1);
|
||||
rt2x00pci_register_write(rt2x00dev, GPIO_CTRL_CFG, reg);
|
||||
|
||||
/*
|
||||
* Initialize hw specifications.
|
||||
*/
|
||||
|
|
|
@ -736,6 +736,7 @@ static int rt2800usb_validate_eeprom(struct rt2x00_dev *rt2x00dev)
|
|||
static int rt2800usb_probe_hw(struct rt2x00_dev *rt2x00dev)
|
||||
{
|
||||
int retval;
|
||||
u32 reg;
|
||||
|
||||
/*
|
||||
* Allocate eeprom data.
|
||||
|
@ -748,6 +749,14 @@ static int rt2800usb_probe_hw(struct rt2x00_dev *rt2x00dev)
|
|||
if (retval)
|
||||
return retval;
|
||||
|
||||
/*
|
||||
* Enable rfkill polling by setting GPIO direction of the
|
||||
* rfkill switch GPIO pin correctly.
|
||||
*/
|
||||
rt2x00usb_register_read(rt2x00dev, GPIO_CTRL_CFG, ®);
|
||||
rt2x00_set_field32(®, GPIO_CTRL_CFG_GPIOD_BIT2, 1);
|
||||
rt2x00usb_register_write(rt2x00dev, GPIO_CTRL_CFG, reg);
|
||||
|
||||
/*
|
||||
* Initialize hw specifications.
|
||||
*/
|
||||
|
|
|
@ -2832,6 +2832,7 @@ static int rt61pci_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
|
|||
static int rt61pci_probe_hw(struct rt2x00_dev *rt2x00dev)
|
||||
{
|
||||
int retval;
|
||||
u32 reg;
|
||||
|
||||
/*
|
||||
* Disable power saving.
|
||||
|
@ -2849,6 +2850,14 @@ static int rt61pci_probe_hw(struct rt2x00_dev *rt2x00dev)
|
|||
if (retval)
|
||||
return retval;
|
||||
|
||||
/*
|
||||
* Enable rfkill polling by setting GPIO direction of the
|
||||
* rfkill switch GPIO pin correctly.
|
||||
*/
|
||||
rt2x00pci_register_read(rt2x00dev, MAC_CSR13, ®);
|
||||
rt2x00_set_field32(®, MAC_CSR13_BIT13, 1);
|
||||
rt2x00pci_register_write(rt2x00dev, MAC_CSR13, reg);
|
||||
|
||||
/*
|
||||
* Initialize hw specifications.
|
||||
*/
|
||||
|
|
|
@ -372,6 +372,7 @@ struct hw_pairwise_ta_entry {
|
|||
#define MAC_CSR13_BIT10 FIELD32(0x00000400)
|
||||
#define MAC_CSR13_BIT11 FIELD32(0x00000800)
|
||||
#define MAC_CSR13_BIT12 FIELD32(0x00001000)
|
||||
#define MAC_CSR13_BIT13 FIELD32(0x00002000)
|
||||
|
||||
/*
|
||||
* MAC_CSR14: LED control register.
|
||||
|
|
|
@ -2177,6 +2177,7 @@ static int rt73usb_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
|
|||
static int rt73usb_probe_hw(struct rt2x00_dev *rt2x00dev)
|
||||
{
|
||||
int retval;
|
||||
u32 reg;
|
||||
|
||||
/*
|
||||
* Allocate eeprom data.
|
||||
|
@ -2189,6 +2190,14 @@ static int rt73usb_probe_hw(struct rt2x00_dev *rt2x00dev)
|
|||
if (retval)
|
||||
return retval;
|
||||
|
||||
/*
|
||||
* Enable rfkill polling by setting GPIO direction of the
|
||||
* rfkill switch GPIO pin correctly.
|
||||
*/
|
||||
rt2x00usb_register_read(rt2x00dev, MAC_CSR13, ®);
|
||||
rt2x00_set_field32(®, MAC_CSR13_BIT15, 0);
|
||||
rt2x00usb_register_write(rt2x00dev, MAC_CSR13, reg);
|
||||
|
||||
/*
|
||||
* Initialize hw specifications.
|
||||
*/
|
||||
|
|
|
@ -282,6 +282,9 @@ struct hw_pairwise_ta_entry {
|
|||
#define MAC_CSR13_BIT10 FIELD32(0x00000400)
|
||||
#define MAC_CSR13_BIT11 FIELD32(0x00000800)
|
||||
#define MAC_CSR13_BIT12 FIELD32(0x00001000)
|
||||
#define MAC_CSR13_BIT13 FIELD32(0x00002000)
|
||||
#define MAC_CSR13_BIT14 FIELD32(0x00004000)
|
||||
#define MAC_CSR13_BIT15 FIELD32(0x00008000)
|
||||
|
||||
/*
|
||||
* MAC_CSR14: LED control register.
|
||||
|
|
Loading…
Reference in New Issue