xfrm: fix policy unreferencing on larval drop
I mistakenly had the error path to use num_pols to decide how many policies we need to drop (cruft from earlier patch set version which did not handle socket policies right). This is wrong since normally we do not keep explicit references (instead we hold reference to the cache entry which holds references to policies). drop_pols is set to num_pols if we are holding the references, so use that. Otherwise we eventually BUG_ON inside xfrm_policy_destroy due to premature policy deletion. Signed-off-by: Timo Teras <timo.teras@iki.fi> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
a14462f1bd
commit
a1aa348304
|
@ -1805,7 +1805,7 @@ restart:
|
|||
/* EREMOTE tells the caller to generate
|
||||
* a one-shot blackhole route. */
|
||||
dst_release(dst);
|
||||
xfrm_pols_put(pols, num_pols);
|
||||
xfrm_pols_put(pols, drop_pols);
|
||||
XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTNOSTATES);
|
||||
return -EREMOTE;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue