USB: uss720: add debug endpoint-type check

Use the new endpoint helpers to lookup the interrupt-in endpoint,
and only print the corresponding debugging information in case it is
found.

Note that the descriptors are searched in reverse order to avoid any
regressions.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2017-03-17 11:35:44 +01:00 committed by Greg Kroah-Hartman
parent aac96ef9ed
commit 9fdc1c6fdf
1 changed files with 6 additions and 4 deletions

View File

@ -689,7 +689,7 @@ static int uss720_probe(struct usb_interface *intf,
{ {
struct usb_device *usbdev = usb_get_dev(interface_to_usbdev(intf)); struct usb_device *usbdev = usb_get_dev(interface_to_usbdev(intf));
struct usb_host_interface *interface; struct usb_host_interface *interface;
struct usb_host_endpoint *endpoint; struct usb_endpoint_descriptor *epd;
struct parport_uss720_private *priv; struct parport_uss720_private *priv;
struct parport *pp; struct parport *pp;
unsigned char reg; unsigned char reg;
@ -740,9 +740,11 @@ static int uss720_probe(struct usb_interface *intf,
get_1284_register(pp, 0, &reg, GFP_KERNEL); get_1284_register(pp, 0, &reg, GFP_KERNEL);
dev_dbg(&intf->dev, "reg: %7ph\n", priv->reg); dev_dbg(&intf->dev, "reg: %7ph\n", priv->reg);
endpoint = &interface->endpoint[2]; i = usb_find_last_int_in_endpoint(interface, &epd);
dev_dbg(&intf->dev, "epaddr %d interval %d\n", if (!i) {
endpoint->desc.bEndpointAddress, endpoint->desc.bInterval); dev_dbg(&intf->dev, "epaddr %d interval %d\n",
epd->bEndpointAddress, epd->bInterval);
}
parport_announce_port(pp); parport_announce_port(pp);
usb_set_intfdata(intf, pp); usb_set_intfdata(intf, pp);