UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

lib: dynamic_debug: no need to check return value of debugfs_create functions 

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: linux-kernel@vger.kernel.org
Acked-by: Jason Baron <jbaron@akamai.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2019-06-12 17:35:34 +02:00
parent 4a14abc4bb
commit 9fd714cd7f
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/dynamic_debug.c
View File

@ -993,20 +993,14 @@ static __initdata int ddebug_init_success;
static int __init dynamic_debug_init_debugfs(void) static int __init dynamic_debug_init_debugfs(void)
{ {
struct dentry *dir, *file; struct dentry *dir;
if (!ddebug_init_success) if (!ddebug_init_success)
return -ENODEV; return -ENODEV;
dir = debugfs_create_dir("dynamic_debug", NULL); dir = debugfs_create_dir("dynamic_debug", NULL);
if (!dir) debugfs_create_file("control", 0644, dir, NULL, &ddebug_proc_fops);
return -ENOMEM;
file = debugfs_create_file("control", 0644, dir, NULL,
&ddebug_proc_fops);
if (!file) {
debugfs_remove(dir);
return -ENOMEM;
}
return 0; return 0;
} }