gpio: twl4030: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. This also makes the driver start to return the error code, as the end of the series make this work. Cc: Roger Quadros <rogerq@ti.com> Cc: Tony Lindgren <tony@atomide.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
27ca226711
commit
9e8014fcaf
|
@ -327,7 +327,7 @@ static int twl_get(struct gpio_chip *chip, unsigned offset)
|
|||
else
|
||||
status = twl4030_get_gpio_datain(offset);
|
||||
|
||||
ret = (status <= 0) ? 0 : 1;
|
||||
ret = (status < 0) ? status : !!status;
|
||||
out:
|
||||
mutex_unlock(&priv->mutex);
|
||||
return ret;
|
||||
|
|
Loading…
Reference in New Issue