UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: pi433: remove register debug dev_dbg stmts using DEBUG_VALUES 

Which the recent addition of the debugfs dentry (regs), users can now
obtain rf69 register values without having to tweak constants
(DEBUG_VALUES) and recompile the pi433 module source code in order to
see those values.

This patch removes code blocks made obsolete by debugfs regs file.

Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
Link: https://lore.kernel.org/r/Yf9ivRB5qpmA5rY2@mail.google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Paulo Miguel Almeida 2022-02-06 18:55:09 +13:00 committed by Greg Kroah-Hartman
parent 1715618496
commit 9e223aa451
1 changed files with 2 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
drivers/staging/pi433/rf69.c
View File

@ -8,8 +8,6 @@
/* enable prosa debug info */ /* enable prosa debug info */
#undef DEBUG #undef DEBUG
/* enable print of values on reg access */
#undef DEBUG_VALUES
/* enable print of values on fifo access */ /* enable print of values on fifo access */
#undef DEBUG_FIFO_ACCESS #undef DEBUG_FIFO_ACCESS
@ -26,48 +24,17 @@
u8 rf69_read_reg(struct spi_device *spi, u8 addr) u8 rf69_read_reg(struct spi_device *spi, u8 addr)
{ {
int retval; return spi_w8r8(spi, addr);
retval = spi_w8r8(spi, addr);
#ifdef DEBUG_VALUES
if (retval < 0)
/*
* should never happen, since we already checked,
* that module is connected. Therefore no error
* handling, just an optional error message...
*/
dev_dbg(&spi->dev, "read 0x%x FAILED\n", addr);
else
dev_dbg(&spi->dev, "read 0x%x from reg 0x%x\n", retval, addr);
#endif
return retval;
} }
static int rf69_write_reg(struct spi_device *spi, u8 addr, u8 value) static int rf69_write_reg(struct spi_device *spi, u8 addr, u8 value)
{ {
int retval;
char buffer[2]; char buffer[2];
buffer[0] = addr | WRITE_BIT; buffer[0] = addr | WRITE_BIT;
buffer[1] = value; buffer[1] = value;
retval = spi_write(spi, &buffer, 2); return spi_write(spi, &buffer, ARRAY_SIZE(buffer));
#ifdef DEBUG_VALUES
if (retval < 0)
/*
* should never happen, since we already checked,
* that module is connected. Therefore no error
* handling, just an optional error message...
*/
dev_dbg(&spi->dev, "write 0x%x to 0x%x FAILED\n", value, addr);
else
dev_dbg(&spi->dev, "wrote 0x%x to reg 0x%x\n", value, addr);
#endif
return retval;
} }
/*-------------------------------------------------------------------------*/ /*-------------------------------------------------------------------------*/