NFS: Use nfs_refresh_inode() in ops that aren't expected to change the inode

nfs_post_op_update_inode() is really only meant to be used if we expect the
inode and its attributes to have changed in some way.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
Trond Myklebust 2007-10-08 14:10:31 -04:00
parent 220bcc2afd
commit 9e08a3c5ae
2 changed files with 3 additions and 5 deletions

View File

@ -777,8 +777,7 @@ static int nfs3_commit_done(struct rpc_task *task, struct nfs_write_data *data)
{ {
if (nfs3_async_handle_jukebox(task, data->inode)) if (nfs3_async_handle_jukebox(task, data->inode))
return -EAGAIN; return -EAGAIN;
if (task->tk_status >= 0) nfs_refresh_inode(data->inode, data->res.fattr);
nfs_post_op_update_inode(data->inode, data->res.fattr);
return 0; return 0;
} }

View File

@ -2475,8 +2475,7 @@ static int nfs4_commit_done(struct rpc_task *task, struct nfs_write_data *data)
rpc_restart_call(task); rpc_restart_call(task);
return -EAGAIN; return -EAGAIN;
} }
if (task->tk_status >= 0) nfs_refresh_inode(inode, data->res.fattr);
nfs_post_op_update_inode(inode, data->res.fattr);
return 0; return 0;
} }
@ -3046,7 +3045,7 @@ static int _nfs4_proc_delegreturn(struct inode *inode, struct rpc_cred *cred, co
if (status == 0) { if (status == 0) {
status = data->rpc_status; status = data->rpc_status;
if (status == 0) if (status == 0)
nfs_post_op_update_inode(inode, &data->fattr); nfs_refresh_inode(inode, &data->fattr);
} }
rpc_put_task(task); rpc_put_task(task);
return status; return status;