UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

accel/habanalabs: change COMMS warning messages to error level 

COMMS protocol is used for LKD <--> FW communication, and any
communication failure between the two might turn out to be
destructive, hence, it should be well emphasized.

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
This commit is contained in:
Koby Elbaz 2023-03-21 16:03:07 +02:00 committed by Oded Gabbay
parent fb10da9337
commit 9d7fef7c59
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/accel/habanalabs/common/firmware_if.c
View File

@ -1263,7 +1263,7 @@ void hl_fw_ask_hard_reset_without_linux(struct hl_device *hdev)
COMMS_RST_DEV, 0, false, COMMS_RST_DEV, 0, false,
hdev->fw_loader.cpu_timeout); hdev->fw_loader.cpu_timeout);
if (rc) if (rc)
dev_warn(hdev->dev, "Failed sending COMMS_RST_DEV\n"); dev_err(hdev->dev, "Failed sending COMMS_RST_DEV\n");
} else { } else {
WREG32(static_loader->kmd_msg_to_cpu_reg, KMD_MSG_RST_DEV); WREG32(static_loader->kmd_msg_to_cpu_reg, KMD_MSG_RST_DEV);
} }
@ -1284,7 +1284,7 @@ void hl_fw_ask_halt_machine_without_linux(struct hl_device *hdev)
COMMS_GOTO_WFE, 0, true, COMMS_GOTO_WFE, 0, true,
hdev->fw_loader.cpu_timeout); hdev->fw_loader.cpu_timeout);
if (rc) if (rc)
dev_warn(hdev->dev, "Failed sending COMMS_GOTO_WFE\n"); dev_err(hdev->dev, "Failed sending COMMS_GOTO_WFE\n");
} else { } else {
WREG32(static_loader->kmd_msg_to_cpu_reg, KMD_MSG_GOTO_WFE); WREG32(static_loader->kmd_msg_to_cpu_reg, KMD_MSG_GOTO_WFE);
msleep(static_loader->cpu_reset_wait_msec); msleep(static_loader->cpu_reset_wait_msec);