UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

Staging: rtl8723bs: Use !x instead of NULL comparison 

If "x" is compared to NULL, use "!x" instead of it, so as
to follow the kernel coding style.

Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Shreeya Patel 2018-01-24 05:43:02 +05:30 committed by Greg Kroah-Hartman
parent 1babeb0c3e
commit 9d03032d30
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/staging/rtl8723bs/hal/sdio_ops.c
View File

@ -215,7 +215,7 @@ static u32 sdio_read32(struct intf_hdl *intfhdl, u32 addr)
u8 *tmpbuf; u8 *tmpbuf;
tmpbuf = rtw_malloc(8); tmpbuf = rtw_malloc(8);
if (NULL == tmpbuf) { if (!tmpbuf) {
DBG_8192C(KERN_ERR "%s: Allocate memory FAIL!(size =8) addr = 0x%x\n", __func__, addr); DBG_8192C(KERN_ERR "%s: Allocate memory FAIL!(size =8) addr = 0x%x\n", __func__, addr);
return SDIO_ERR_VAL32; return SDIO_ERR_VAL32;
} }
@ -264,7 +264,7 @@ static s32 sdio_readN(struct intf_hdl *intfhdl, u32 addr, u32 cnt, u8 *buf)
ftaddr &= ~(u16)0x3; ftaddr &= ~(u16)0x3;
n = cnt + shift; n = cnt + shift;
tmpbuf = rtw_malloc(n); tmpbuf = rtw_malloc(n);
if (NULL == tmpbuf) if (!tmpbuf)
return -1; return -1;
err = sd_read(intfhdl, ftaddr, n, tmpbuf); err = sd_read(intfhdl, ftaddr, n, tmpbuf);
@ -367,7 +367,7 @@ static s32 sdio_writeN(struct intf_hdl *intfhdl, u32 addr, u32 cnt, u8 *buf)
ftaddr &= ~(u16)0x3; ftaddr &= ~(u16)0x3;
n = cnt + shift; n = cnt + shift;
tmpbuf = rtw_malloc(n); tmpbuf = rtw_malloc(n);
if (NULL == tmpbuf) if (!tmpbuf)
return -1; return -1;
err = sd_read(intfhdl, ftaddr, 4, tmpbuf); err = sd_read(intfhdl, ftaddr, 4, tmpbuf);
if (err) { if (err) {
@ -730,7 +730,7 @@ static s32 ReadInterrupt8723BSdio(struct adapter *adapter, u32 *phisr)
u8 val8, hisr_len; u8 val8, hisr_len;
if (phisr == NULL) if (!phisr)
return false; return false;
himr = GET_HAL_DATA(adapter)->sdio_himr; himr = GET_HAL_DATA(adapter)->sdio_himr;
@ -954,13 +954,13 @@ static struct recv_buf *sd_recv_rxfifo(struct adapter *adapter, u32 size)
/* 3 1. alloc recvbuf */ /* 3 1. alloc recvbuf */
recv_priv = &adapter->recvpriv; recv_priv = &adapter->recvpriv;
recvbuf = rtw_dequeue_recvbuf(&recv_priv->free_recv_buf_queue); recvbuf = rtw_dequeue_recvbuf(&recv_priv->free_recv_buf_queue);
if (recvbuf == NULL) { if (!recvbuf) {
DBG_871X_LEVEL(_drv_err_, "%s: alloc recvbuf FAIL!\n", __func__); DBG_871X_LEVEL(_drv_err_, "%s: alloc recvbuf FAIL!\n", __func__);
return NULL; return NULL;
} }
/* 3 2. alloc skb */ /* 3 2. alloc skb */
if (recvbuf->pskb == NULL) { if (!recvbuf->pskb) {
SIZE_PTR tmpaddr = 0; SIZE_PTR tmpaddr = 0;
SIZE_PTR alignment = 0; SIZE_PTR alignment = 0;
@ -974,7 +974,7 @@ static struct recv_buf *sd_recv_rxfifo(struct adapter *adapter, u32 size)
skb_reserve(recvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment)); skb_reserve(recvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
} }
if (recvbuf->pskb == NULL) { if (!recvbuf->pskb) {
DBG_871X("%s: alloc_skb fail! read =%d\n", __func__, readsize); DBG_871X("%s: alloc_skb fail! read =%d\n", __func__, readsize);
return NULL; return NULL;
} }
@ -1232,7 +1232,7 @@ u8 RecvOnePkt(struct adapter *adapter, u32 size)
DBG_871X("+%s: size: %d+\n", __func__, size); DBG_871X("+%s: size: %d+\n", __func__, size);
if (adapter == NULL) { if (!adapter) {
DBG_871X(KERN_ERR "%s: adapter is NULL!\n", __func__); DBG_871X(KERN_ERR "%s: adapter is NULL!\n", __func__);
return false; return false;
} }