UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

RDMA/bnxt_re: Fix to remove unnecessary return labels 

If there is no cleanup needed then just return directly.  This cleans up
the code and improve readability.

Fixes: 1ac5a40479 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
Link: https://lore.kernel.org/r/1684478897-12247-3-git-send-email-selvin.xavier@broadcom.com
Reviewed-by: Kashyap Desai <kashyap.desai@broadcom.com>
Reviewed-by: Saravanan Vajravel <saravanan.vajravel@broadcom.com>
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
This commit is contained in:
Kalesh AP 2023-05-18 23:48:12 -07:00 committed by Jason Gunthorpe
parent ab112ee789
commit 9b3ee47796
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/infiniband/hw/bnxt_re/qplib_fp.c
View File

@ -1618,7 +1618,7 @@ static int bnxt_qplib_put_inline(struct bnxt_qplib_qp *qp,
il_src = (void *)wqe->sg_list[indx].addr; il_src = (void *)wqe->sg_list[indx].addr;
t_len += len; t_len += len;
if (t_len > qp->max_inline_data) if (t_len > qp->max_inline_data)
goto bad; return -ENOMEM;
while (len) { while (len) {
if (pull_dst) { if (pull_dst) {
pull_dst = false; pull_dst = false;
@ -1642,8 +1642,6 @@ static int bnxt_qplib_put_inline(struct bnxt_qplib_qp *qp,
} }
return t_len; return t_len;
bad:
return -ENOMEM;
} }
static u32 bnxt_qplib_put_sges(struct bnxt_qplib_hwq *hwq, static u32 bnxt_qplib_put_sges(struct bnxt_qplib_hwq *hwq,
@ -2067,7 +2065,7 @@ int bnxt_qplib_create_cq(struct bnxt_qplib_res *res, struct bnxt_qplib_cq *cq)
hwq_attr.sginfo = &cq->sg_info; hwq_attr.sginfo = &cq->sg_info;
rc = bnxt_qplib_alloc_init_hwq(&cq->hwq, &hwq_attr); rc = bnxt_qplib_alloc_init_hwq(&cq->hwq, &hwq_attr);
if (rc) if (rc)
goto exit; return rc;
bnxt_qplib_rcfw_cmd_prep((struct cmdq_base *)&req, bnxt_qplib_rcfw_cmd_prep((struct cmdq_base *)&req,
CMDQ_BASE_OPCODE_CREATE_CQ, CMDQ_BASE_OPCODE_CREATE_CQ,
@ -2115,7 +2113,6 @@ int bnxt_qplib_create_cq(struct bnxt_qplib_res *res, struct bnxt_qplib_cq *cq)
fail: fail:
bnxt_qplib_free_hwq(res, &cq->hwq); bnxt_qplib_free_hwq(res, &cq->hwq);
exit:
return rc; return rc;
} }