UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: freescale: select CONFIG_FIXED_PHY where needed 

I ran into a randconfig build failure with CONFIG_FIXED_PHY=m
and CONFIG_GIANFAR=y:

x86_64-linux-ld: drivers/net/ethernet/freescale/gianfar.o:(.rodata+0x418): undefined reference to `fixed_phy_change_carrier'

It seems the same thing can happen with dpaa and ucc_geth, so change
all three to do an explicit 'select FIXED_PHY'.

The fixed-phy driver actually has an alternative stub function that
theoretically allows building network drivers when fixed-phy is
disabled, but I don't see how that would help here, as the drivers
presumably would not work then.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Arnd Bergmann 2020-05-09 14:04:52 +02:00 committed by Jakub Kicinski
parent 57644431a6
commit 99352c79af
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/freescale/Kconfig
View File

@ -77,6 +77,7 @@ config UCC_GETH
depends on QUICC_ENGINE && PPC32 depends on QUICC_ENGINE && PPC32
select FSL_PQ_MDIO select FSL_PQ_MDIO
select PHYLIB select PHYLIB
select FIXED_PHY
---help--- ---help---
This driver supports the Gigabit Ethernet mode of the QUICC Engine, This driver supports the Gigabit Ethernet mode of the QUICC Engine,
which is available on some Freescale SOCs. which is available on some Freescale SOCs.
@ -90,6 +91,7 @@ config GIANFAR
depends on HAS_DMA depends on HAS_DMA
select FSL_PQ_MDIO select FSL_PQ_MDIO
select PHYLIB select PHYLIB
select FIXED_PHY
select CRC32 select CRC32
---help--- ---help---
This driver supports the Gigabit TSEC on the MPC83xx, MPC85xx, This driver supports the Gigabit TSEC on the MPC83xx, MPC85xx,

1
drivers/net/ethernet/freescale/dpaa/Kconfig
View File

@ -3,6 +3,7 @@ menuconfig FSL_DPAA_ETH
tristate "DPAA Ethernet" tristate "DPAA Ethernet"
depends on FSL_DPAA && FSL_FMAN depends on FSL_DPAA && FSL_FMAN
select PHYLIB select PHYLIB
select FIXED_PHY
select FSL_FMAN_MAC select FSL_FMAN_MAC
---help--- ---help---
Data Path Acceleration Architecture Ethernet driver, Data Path Acceleration Architecture Ethernet driver,