drm/i915: Pass crtc_state down to skl dpll funcs
Simplify the calling convention of the skl dpll funcs by plumbing the crtc state deeper. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190207173230.22368-3-ville.syrjala@linux.intel.com Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
This commit is contained in:
parent
cc089e8abe
commit
98b6072c2a
|
@ -1307,9 +1307,7 @@ skip_remaining_dividers:
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
static bool skl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc,
|
static bool skl_ddi_hdmi_pll_dividers(struct intel_crtc_state *crtc_state)
|
||||||
struct intel_crtc_state *crtc_state,
|
|
||||||
int clock)
|
|
||||||
{
|
{
|
||||||
u32 ctrl1, cfgcr1, cfgcr2;
|
u32 ctrl1, cfgcr1, cfgcr2;
|
||||||
struct skl_wrpll_params wrpll_params = { 0, };
|
struct skl_wrpll_params wrpll_params = { 0, };
|
||||||
|
@ -1322,7 +1320,8 @@ static bool skl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc,
|
||||||
|
|
||||||
ctrl1 |= DPLL_CTRL1_HDMI_MODE(0);
|
ctrl1 |= DPLL_CTRL1_HDMI_MODE(0);
|
||||||
|
|
||||||
if (!skl_ddi_calculate_wrpll(clock * 1000, &wrpll_params))
|
if (!skl_ddi_calculate_wrpll(crtc_state->port_clock * 1000,
|
||||||
|
&wrpll_params))
|
||||||
return false;
|
return false;
|
||||||
|
|
||||||
cfgcr1 = DPLL_CFGCR1_FREQ_ENABLE |
|
cfgcr1 = DPLL_CFGCR1_FREQ_ENABLE |
|
||||||
|
@ -1345,7 +1344,7 @@ static bool skl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc,
|
||||||
}
|
}
|
||||||
|
|
||||||
static bool
|
static bool
|
||||||
skl_ddi_dp_set_dpll_hw_state(int clock,
|
skl_ddi_dp_set_dpll_hw_state(struct intel_crtc_state *crtc_state,
|
||||||
struct intel_dpll_hw_state *dpll_hw_state)
|
struct intel_dpll_hw_state *dpll_hw_state)
|
||||||
{
|
{
|
||||||
u32 ctrl1;
|
u32 ctrl1;
|
||||||
|
@ -1355,7 +1354,7 @@ skl_ddi_dp_set_dpll_hw_state(int clock,
|
||||||
* as the DPLL id in this function.
|
* as the DPLL id in this function.
|
||||||
*/
|
*/
|
||||||
ctrl1 = DPLL_CTRL1_OVERRIDE(0);
|
ctrl1 = DPLL_CTRL1_OVERRIDE(0);
|
||||||
switch (clock / 2) {
|
switch (crtc_state->port_clock / 2) {
|
||||||
case 81000:
|
case 81000:
|
||||||
ctrl1 |= DPLL_CTRL1_LINK_RATE(DPLL_CTRL1_LINK_RATE_810, 0);
|
ctrl1 |= DPLL_CTRL1_LINK_RATE(DPLL_CTRL1_LINK_RATE_810, 0);
|
||||||
break;
|
break;
|
||||||
|
@ -1385,22 +1384,20 @@ static struct intel_shared_dpll *
|
||||||
skl_get_dpll(struct intel_crtc_state *crtc_state,
|
skl_get_dpll(struct intel_crtc_state *crtc_state,
|
||||||
struct intel_encoder *encoder)
|
struct intel_encoder *encoder)
|
||||||
{
|
{
|
||||||
struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
|
|
||||||
struct intel_shared_dpll *pll;
|
struct intel_shared_dpll *pll;
|
||||||
int clock = crtc_state->port_clock;
|
|
||||||
bool bret;
|
bool bret;
|
||||||
struct intel_dpll_hw_state dpll_hw_state;
|
struct intel_dpll_hw_state dpll_hw_state;
|
||||||
|
|
||||||
memset(&dpll_hw_state, 0, sizeof(dpll_hw_state));
|
memset(&dpll_hw_state, 0, sizeof(dpll_hw_state));
|
||||||
|
|
||||||
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) {
|
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) {
|
||||||
bret = skl_ddi_hdmi_pll_dividers(crtc, crtc_state, clock);
|
bret = skl_ddi_hdmi_pll_dividers(crtc_state);
|
||||||
if (!bret) {
|
if (!bret) {
|
||||||
DRM_DEBUG_KMS("Could not get HDMI pll dividers.\n");
|
DRM_DEBUG_KMS("Could not get HDMI pll dividers.\n");
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
} else if (intel_crtc_has_dp_encoder(crtc_state)) {
|
} else if (intel_crtc_has_dp_encoder(crtc_state)) {
|
||||||
bret = skl_ddi_dp_set_dpll_hw_state(clock, &dpll_hw_state);
|
bret = skl_ddi_dp_set_dpll_hw_state(crtc_state, &dpll_hw_state);
|
||||||
if (!bret) {
|
if (!bret) {
|
||||||
DRM_DEBUG_KMS("Could not set DP dpll HW state.\n");
|
DRM_DEBUG_KMS("Could not set DP dpll HW state.\n");
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
Loading…
Reference in New Issue