RDS: Turn down alarming reconnect messages

RDS's error messages when a connection goes down are a little
extreme. A connection may go down, and it will be re-established,
and everything is fine. This patch links these messages through
rdsdebug(), instead of to printk directly.

Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Andy Grover 2010-03-11 13:50:02 +00:00 committed by David S. Miller
parent 571c02fa81
commit 97069788d6
3 changed files with 6 additions and 3 deletions

View File

@ -203,9 +203,10 @@ static void rds_ib_qp_event_handler(struct ib_event *event, void *data)
rdma_notify(ic->i_cm_id, IB_EVENT_COMM_EST); rdma_notify(ic->i_cm_id, IB_EVENT_COMM_EST);
break; break;
default: default:
rds_ib_conn_error(conn, "RDS/IB: Fatal QP Event %u " rdsdebug("Fatal QP Event %u "
"- connection %pI4->%pI4, reconnecting\n", "- connection %pI4->%pI4, reconnecting\n",
event->event, &conn->c_laddr, &conn->c_faddr); event->event, &conn->c_laddr, &conn->c_faddr);
rds_conn_drop(conn);
break; break;
} }
} }

View File

@ -156,9 +156,11 @@ static void rds_iw_qp_event_handler(struct ib_event *event, void *data)
case IB_EVENT_QP_REQ_ERR: case IB_EVENT_QP_REQ_ERR:
case IB_EVENT_QP_FATAL: case IB_EVENT_QP_FATAL:
default: default:
rds_iw_conn_error(conn, "RDS/IW: Fatal QP Event %u - connection %pI4->%pI4...reconnecting\n", rdsdebug("Fatal QP Event %u "
"- connection %pI4->%pI4, reconnecting\n",
event->event, &conn->c_laddr, event->event, &conn->c_laddr,
&conn->c_faddr); &conn->c_faddr);
rds_conn_drop(conn);
break; break;
} }
} }

View File

@ -101,7 +101,7 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id *cm_id,
break; break;
case RDMA_CM_EVENT_DISCONNECTED: case RDMA_CM_EVENT_DISCONNECTED:
printk(KERN_WARNING "RDS/RDMA: DISCONNECT event - dropping connection " rdsdebug("DISCONNECT event - dropping connection "
"%pI4->%pI4\n", &conn->c_laddr, "%pI4->%pI4\n", &conn->c_laddr,
&conn->c_faddr); &conn->c_faddr);
rds_conn_drop(conn); rds_conn_drop(conn);