UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

io_uring: keep io_req_free_batch() call locality 

Don't do a function call (io_dismantle_req()) in the middle and place it
to near other function calls, otherwise may lead to excessive register
spilling.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Pavel Begunkov 2021-03-19 17:22:32 +00:00 committed by Jens Axboe
parent cf27f3b149
commit 966706579a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/io_uring.c
View File

@ -2112,6 +2112,7 @@ static void io_req_free_batch(struct req_batch *rb, struct io_kiocb *req,
struct io_submit_state *state) struct io_submit_state *state)
{ {
io_queue_next(req); io_queue_next(req);
io_dismantle_req(req);
if (req->task != rb->task) { if (req->task != rb->task) {
if (rb->task) if (rb->task)
@ -2122,7 +2123,6 @@ static void io_req_free_batch(struct req_batch *rb, struct io_kiocb *req,
rb->task_refs++; rb->task_refs++;
rb->ctx_refs++; rb->ctx_refs++;
io_dismantle_req(req);
if (state->free_reqs != ARRAY_SIZE(state->reqs)) if (state->free_reqs != ARRAY_SIZE(state->reqs))
state->reqs[state->free_reqs++] = req; state->reqs[state->free_reqs++] = req;
else else