UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

rtc: isl12022: Explicitly use __le16 type for ISL12022_REG_TEMP_L 

We are reading 10-bit value in a 16-bit register in LE format.
Make this explicit by using __le16 type for it and corresponding
conversion function.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Link: https://lore.kernel.org/r/20230110140806.87432-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Andy Shevchenko 2023-01-10 16:08:03 +02:00 committed by Alexandre Belloni
parent f525b210e9
commit 93219a4fb8
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/rtc/rtc-isl12022.c
View File

@ -19,6 +19,8 @@
#include <linux/regmap.h> #include <linux/regmap.h>
#include <linux/hwmon.h> #include <linux/hwmon.h>
#include <asm/byteorder.h>
/* ISL register offsets */ /* ISL register offsets */
#define ISL12022_REG_SC 0x00 #define ISL12022_REG_SC 0x00
#define ISL12022_REG_MN 0x01 #define ISL12022_REG_MN 0x01
@ -63,17 +65,16 @@ static umode_t isl12022_hwmon_is_visible(const void *data,
static int isl12022_hwmon_read_temp(struct device *dev, long *mC) static int isl12022_hwmon_read_temp(struct device *dev, long *mC)
{ {
struct regmap *regmap = dev_get_drvdata(dev); struct regmap *regmap = dev_get_drvdata(dev);
u8 temp_buf[2];
int temp, ret; int temp, ret;
__le16 buf;
ret = regmap_bulk_read(regmap, ISL12022_REG_TEMP_L, ret = regmap_bulk_read(regmap, ISL12022_REG_TEMP_L, &buf, sizeof(buf));
temp_buf, sizeof(temp_buf));
if (ret) if (ret)
return ret; return ret;
/* /*
* Temperature is represented as a 10-bit number, unit half-Kelvins. * Temperature is represented as a 10-bit number, unit half-Kelvins.
*/ */
temp = (temp_buf[1] << 8) | temp_buf[0]; temp = le16_to_cpu(buf);
temp *= 500; temp *= 500;
temp -= 273000; temp -= 273000;