UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

spi: rzv2m-csi: Convert to platform remove callback returning void 

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230707071119.3394198-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-07-07 09:11:19 +02:00 committed by Mark Brown
parent 15a6af94a2
commit 9303331461
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/spi/spi-rzv2m-csi.c
View File

@ -635,15 +635,13 @@ static int rzv2m_csi_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int rzv2m_csi_remove(struct platform_device *pdev) static void rzv2m_csi_remove(struct platform_device *pdev)
{ {
struct rzv2m_csi_priv *csi = platform_get_drvdata(pdev); struct rzv2m_csi_priv *csi = platform_get_drvdata(pdev);
spi_unregister_controller(csi->controller); spi_unregister_controller(csi->controller);
rzv2m_csi_sw_reset(csi, 1); rzv2m_csi_sw_reset(csi, 1);
clk_disable_unprepare(csi->csiclk); clk_disable_unprepare(csi->csiclk);
return 0;
} }
static const struct of_device_id rzv2m_csi_match[] = { static const struct of_device_id rzv2m_csi_match[] = {
@ -654,7 +652,7 @@ MODULE_DEVICE_TABLE(of, rzv2m_csi_match);
static struct platform_driver rzv2m_csi_drv = { static struct platform_driver rzv2m_csi_drv = {
.probe = rzv2m_csi_probe, .probe = rzv2m_csi_probe,
.remove = rzv2m_csi_remove, .remove_new = rzv2m_csi_remove,
.driver = { .driver = {
.name = "rzv2m_csi", .name = "rzv2m_csi",
.of_match_table = rzv2m_csi_match, .of_match_table = rzv2m_csi_match,