pds_core: use vmalloc_array and vcalloc
Use vmalloc_array and vcalloc to protect against multiplication overflows. The changes were done using the following Coccinelle semantic patch: // <smpl> @initialize:ocaml@ @@ let rename alloc = match alloc with "vmalloc" -> "vmalloc_array" | "vzalloc" -> "vcalloc" | _ -> failwith "unknown" @@ size_t e1,e2; constant C1, C2; expression E1, E2, COUNT, x1, x2, x3; typedef u8; typedef __u8; type t = {u8,__u8,char,unsigned char}; identifier alloc = {vmalloc,vzalloc}; fresh identifier realloc = script:ocaml(alloc) { rename alloc }; @@ ( alloc(x1*x2*x3) | alloc(C1 * C2) | alloc((sizeof(t)) * (COUNT), ...) | - alloc((e1) * (e2)) + realloc(e1, e2) | - alloc((e1) * (COUNT)) + realloc(COUNT, e1) | - alloc((E1) * (E2)) + realloc(E1, E2) ) // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> Link: https://lore.kernel.org/r/20230627144339.144478-10-Julia.Lawall@inria.fr Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
a13de901e8
commit
906a76cc76
|
@ -196,7 +196,7 @@ int pdsc_qcq_alloc(struct pdsc *pdsc, unsigned int type, unsigned int index,
|
|||
dma_addr_t q_base_pa;
|
||||
int err;
|
||||
|
||||
qcq->q.info = vzalloc(num_descs * sizeof(*qcq->q.info));
|
||||
qcq->q.info = vcalloc(num_descs, sizeof(*qcq->q.info));
|
||||
if (!qcq->q.info) {
|
||||
err = -ENOMEM;
|
||||
goto err_out;
|
||||
|
@ -219,7 +219,7 @@ int pdsc_qcq_alloc(struct pdsc *pdsc, unsigned int type, unsigned int index,
|
|||
if (err)
|
||||
goto err_out_free_q_info;
|
||||
|
||||
qcq->cq.info = vzalloc(num_descs * sizeof(*qcq->cq.info));
|
||||
qcq->cq.info = vcalloc(num_descs, sizeof(*qcq->cq.info));
|
||||
if (!qcq->cq.info) {
|
||||
err = -ENOMEM;
|
||||
goto err_out_free_irq;
|
||||
|
|
Loading…
Reference in New Issue