UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

[ROSE]: Fix dereference of skb pointer after free. 

If rose_route_frame return success we'll dereference a stale pointer.
Likely this is only going to result in bad statistics for the ROSE
interface.

This fixes coverity 946.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ralf Baechle 2006-07-03 19:29:15 -07:00 committed by David S. Miller
parent 518d1c9679
commit 8dc22d2b64
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
net/rose/rose_dev.c
View File

@ -59,6 +59,7 @@ static int rose_rebuild_header(struct sk_buff *skb)
struct net_device_stats *stats = netdev_priv(dev); struct net_device_stats *stats = netdev_priv(dev);
unsigned char *bp = (unsigned char *)skb->data; unsigned char *bp = (unsigned char *)skb->data;
struct sk_buff *skbn; struct sk_buff *skbn;
unsigned int len;
#ifdef CONFIG_INET #ifdef CONFIG_INET
if (arp_find(bp + 7, skb)) { if (arp_find(bp + 7, skb)) {
@ -75,6 +76,8 @@ static int rose_rebuild_header(struct sk_buff *skb)
kfree_skb(skb); kfree_skb(skb);
len = skbn->len;
if (!rose_route_frame(skbn, NULL)) { if (!rose_route_frame(skbn, NULL)) {
kfree_skb(skbn); kfree_skb(skbn);
stats->tx_errors++; stats->tx_errors++;
@ -82,7 +85,7 @@ static int rose_rebuild_header(struct sk_buff *skb)
} }
stats->tx_packets++; stats->tx_packets++;
stats->tx_bytes += skbn->len; stats->tx_bytes += len;
#endif #endif
return 1; return 1;
} }