UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

storvsc: use shost_for_each_device() instead of open coding 

Comment in struct Scsi_Host says that drivers are not supposed to access
__devices directly. storvsc_host_scan() doesn't happen in irq context
so we can just use shost_for_each_device().

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Long Li <longli@microsoft.com>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
This commit is contained in:
Vitaly Kuznetsov 2015-07-01 11:31:27 +02:00 committed by James Bottomley
parent cb1cf0804f
commit 8d6a9f5676
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/scsi/storvsc_drv.c
View File

@ -426,7 +426,6 @@ static void storvsc_host_scan(struct work_struct *work)
struct storvsc_scan_work *wrk; struct storvsc_scan_work *wrk;
struct Scsi_Host *host; struct Scsi_Host *host;
struct scsi_device *sdev; struct scsi_device *sdev;
unsigned long flags;
wrk = container_of(work, struct storvsc_scan_work, work); wrk = container_of(work, struct storvsc_scan_work, work);
host = wrk->host; host = wrk->host;
@ -443,14 +442,8 @@ static void storvsc_host_scan(struct work_struct *work)
* may have been removed this way. * may have been removed this way.
*/ */
mutex_lock(&host->scan_mutex); mutex_lock(&host->scan_mutex);
spin_lock_irqsave(host->host_lock, flags); shost_for_each_device(sdev, host)
list_for_each_entry(sdev, &host->__devices, siblings) {
spin_unlock_irqrestore(host->host_lock, flags);
scsi_test_unit_ready(sdev, 1, 1, NULL); scsi_test_unit_ready(sdev, 1, 1, NULL);
spin_lock_irqsave(host->host_lock, flags);
continue;
}
spin_unlock_irqrestore(host->host_lock, flags);
mutex_unlock(&host->scan_mutex); mutex_unlock(&host->scan_mutex);
/* /*
* Now scan the host to discover LUNs that may have been added. * Now scan the host to discover LUNs that may have been added.