UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

crypto: omap-des - Drop if with an always false condition 

The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so dd is never NULL.

This is a preparation for making platform remove callbacks return void.

While touching this driver remove an assignment without effect.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Uwe Kleine-König 2022-07-05 22:51:42 +02:00 committed by Herbert Xu
parent da1e716864
commit 8ce715e711
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/crypto/omap-des.c
View File

@ -1091,9 +1091,6 @@ static int omap_des_remove(struct platform_device *pdev)
struct omap_des_dev *dd = platform_get_drvdata(pdev); struct omap_des_dev *dd = platform_get_drvdata(pdev);
int i, j; int i, j;
if (!dd)
return -ENODEV;
spin_lock_bh(&list_lock); spin_lock_bh(&list_lock);
list_del(&dd->list); list_del(&dd->list);
spin_unlock_bh(&list_lock); spin_unlock_bh(&list_lock);
@ -1106,7 +1103,6 @@ static int omap_des_remove(struct platform_device *pdev)
tasklet_kill(&dd->done_task); tasklet_kill(&dd->done_task);
omap_des_dma_cleanup(dd); omap_des_dma_cleanup(dd);
pm_runtime_disable(dd->dev); pm_runtime_disable(dd->dev);
dd = NULL;
return 0; return 0;
} }