UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

net/mlx5e: Use struct assignment to initialize mlx5e_tx_wqe_info 

Struct assignment guarantees that all fields of the structure are
initialized (those that are not mentioned are zeroed). It makes code
mode robust and reduces chances for unpredictable behavior when one
forgets to reset some field and it holds an old value from previous
iterations of using the structure.

Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
This commit is contained in:
Maxim Mikityanskiy 2020-09-08 10:46:09 +03:00 committed by Saeed Mahameed
parent 6d55af43fe
commit 8ba6f18399
1 changed files with 6 additions and 4 deletions
drivers/net/ethernet/mellanox/mlx5/core
en_tx.c

10
drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
View File

@ -241,10 +241,12 @@ mlx5e_txwqe_complete(struct mlx5e_txqsq *sq, struct sk_buff *skb,
struct mlx5_wq_cyc *wq = &sq->wq;
bool send_doorbell;
wi->num_bytes = num_bytes;
wi->num_dma = num_dma;
wi->num_wqebbs = num_wqebbs;
wi->skb = skb;
*wi = (struct mlx5e_tx_wqe_info) {
.skb = skb,
.num_bytes = num_bytes,
.num_dma = num_dma,
.num_wqebbs = num_wqebbs,
};
cseg->opmod_idx_opcode = cpu_to_be32((sq->pc << 8) | opcode);
cseg->qpn_ds = cpu_to_be32((sq->sqn << 8) | ds_cnt);