UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

perf hists: Enlarge pid sort entry size 

The pid sort entry currently aligns pids with 5 digits, which is not
enough for current 4 million pids limit.

This leads to unaligned ':' header-data output when we display 7 digits
pid:

  # Children      Self  Symbol                    Pid:Command
  # ........  ........  ......................  .....................
  #
       0.12%     0.12%  [.] 0x0000000000147e0f  2052894:krava
  ...

Adding 2 more digit to properly align the pid limit:

  # Children      Self  Symbol                      Pid:Command
  # ........  ........  ......................  .......................
  #
       0.12%     0.12%  [.] 0x0000000000147e0f  2052894:krava

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1466459899-1166-9-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Jiri Olsa 2016-06-20 23:58:19 +02:00 committed by Arnaldo Carvalho de Melo
parent fcd8642650
commit 89c7cb2cad
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/perf/util/hist.c
View File

@ -79,7 +79,7 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h)
len = thread__comm_len(h->thread); len = thread__comm_len(h->thread);
if (hists__new_col_len(hists, HISTC_COMM, len)) if (hists__new_col_len(hists, HISTC_COMM, len))
hists__set_col_len(hists, HISTC_THREAD, len + 6); hists__set_col_len(hists, HISTC_THREAD, len + 8);
if (h->ms.map) { if (h->ms.map) {
len = dso__name_len(h->ms.map->dso); len = dso__name_len(h->ms.map->dso);

6
tools/perf/util/sort.c
View File

@ -79,8 +79,8 @@ static int hist_entry__thread_snprintf(struct hist_entry *he, char *bf,
{ {
const char *comm = thread__comm_str(he->thread); const char *comm = thread__comm_str(he->thread);
width = max(7U, width) - 6; width = max(7U, width) - 8;
return repsep_snprintf(bf, size, "%5d:%-*.*s", he->thread->tid, return repsep_snprintf(bf, size, "%7d:%-*.*s", he->thread->tid,
width, width, comm ?: ""); width, width, comm ?: "");
} }
@ -95,7 +95,7 @@ static int hist_entry__thread_filter(struct hist_entry *he, int type, const void
} }
struct sort_entry sort_thread = { struct sort_entry sort_thread = {
.se_header = " Pid:Command", .se_header = " Pid:Command",
.se_cmp = sort__thread_cmp, .se_cmp = sort__thread_cmp,
.se_snprintf = hist_entry__thread_snprintf, .se_snprintf = hist_entry__thread_snprintf,
.se_filter = hist_entry__thread_filter, .se_filter = hist_entry__thread_filter,