UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

fbdev: wmt_ge_rops: Convert to platform remove callback returning void 

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
Uwe Kleine-König 2023-03-19 00:54:27 +01:00 committed by Helge Deller
parent 024a3cafa5
commit 89c4bbd457
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/video/fbdev/wmt_ge_rops.c
View File

@ -145,10 +145,9 @@ static int wmt_ge_rops_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int wmt_ge_rops_remove(struct platform_device *pdev) static void wmt_ge_rops_remove(struct platform_device *pdev)
{ {
iounmap(regbase); iounmap(regbase);
return 0;
} }
static const struct of_device_id wmt_dt_ids[] = { static const struct of_device_id wmt_dt_ids[] = {
@ -158,7 +157,7 @@ static const struct of_device_id wmt_dt_ids[] = {
static struct platform_driver wmt_ge_rops_driver = { static struct platform_driver wmt_ge_rops_driver = {
.probe = wmt_ge_rops_probe, .probe = wmt_ge_rops_probe,
.remove = wmt_ge_rops_remove, .remove_new = wmt_ge_rops_remove,
.driver = { .driver = {
.name = "wmt_ge_rops", .name = "wmt_ge_rops",
.of_match_table = wmt_dt_ids, .of_match_table = wmt_dt_ids,