[POWERPC] Show EEH per-device false positives
Track and report the number of times we read an all-1s value (0xff, 0xffff or 0xffffffff) from each device which is valid data, not indicating EEH isolation. Signed-off-by: Linas Vepstas <linas@austin.ibm.com> ---- arch/powerpc/platforms/pseries/eeh.c | 5 +++++ arch/powerpc/platforms/pseries/eeh_sysfs.c | 3 +++ include/asm-powerpc/pci-bridge.h | 1 + 3 files changed, 9 insertions(+) Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
parent
e1d04c9769
commit
858955bd57
|
@ -505,6 +505,7 @@ int eeh_dn_check_failure(struct device_node *dn, struct pci_dev *dev)
|
|||
printk(KERN_WARNING "EEH: read_slot_reset_state() failed; rc=%d dn=%s\n",
|
||||
ret, dn->full_name);
|
||||
false_positives++;
|
||||
pdn->eeh_false_positives ++;
|
||||
rc = 0;
|
||||
goto dn_unlock;
|
||||
}
|
||||
|
@ -513,6 +514,7 @@ int eeh_dn_check_failure(struct device_node *dn, struct pci_dev *dev)
|
|||
* they are empty when they don't have children. */
|
||||
if ((rets[0] == 5) && (dn->child == NULL)) {
|
||||
false_positives++;
|
||||
pdn->eeh_false_positives ++;
|
||||
rc = 0;
|
||||
goto dn_unlock;
|
||||
}
|
||||
|
@ -522,6 +524,7 @@ int eeh_dn_check_failure(struct device_node *dn, struct pci_dev *dev)
|
|||
printk(KERN_WARNING "EEH: event on unsupported device, rc=%d dn=%s\n",
|
||||
ret, dn->full_name);
|
||||
false_positives++;
|
||||
pdn->eeh_false_positives ++;
|
||||
rc = 0;
|
||||
goto dn_unlock;
|
||||
}
|
||||
|
@ -529,6 +532,7 @@ int eeh_dn_check_failure(struct device_node *dn, struct pci_dev *dev)
|
|||
/* If not the kind of error we know about, punt. */
|
||||
if (rets[0] != 1 && rets[0] != 2 && rets[0] != 4 && rets[0] != 5) {
|
||||
false_positives++;
|
||||
pdn->eeh_false_positives ++;
|
||||
rc = 0;
|
||||
goto dn_unlock;
|
||||
}
|
||||
|
@ -921,6 +925,7 @@ static void *early_enable_eeh(struct device_node *dn, void *data)
|
|||
pdn->eeh_mode = 0;
|
||||
pdn->eeh_check_count = 0;
|
||||
pdn->eeh_freeze_count = 0;
|
||||
pdn->eeh_false_positives = 0;
|
||||
|
||||
if (status && strcmp(status, "ok") != 0)
|
||||
return NULL; /* ignore devices with bad status */
|
||||
|
|
|
@ -58,6 +58,7 @@ EEH_SHOW_ATTR(eeh_config_addr, eeh_config_addr, "0x%x");
|
|||
EEH_SHOW_ATTR(eeh_pe_config_addr, eeh_pe_config_addr, "0x%x");
|
||||
EEH_SHOW_ATTR(eeh_check_count, eeh_check_count, "%d");
|
||||
EEH_SHOW_ATTR(eeh_freeze_count, eeh_freeze_count, "%d");
|
||||
EEH_SHOW_ATTR(eeh_false_positives, eeh_false_positives, "%d");
|
||||
|
||||
void eeh_sysfs_add_device(struct pci_dev *pdev)
|
||||
{
|
||||
|
@ -67,6 +68,7 @@ void eeh_sysfs_add_device(struct pci_dev *pdev)
|
|||
rc += device_create_file(&pdev->dev, &dev_attr_eeh_config_addr);
|
||||
rc += device_create_file(&pdev->dev, &dev_attr_eeh_pe_config_addr);
|
||||
rc += device_create_file(&pdev->dev, &dev_attr_eeh_check_count);
|
||||
rc += device_create_file(&pdev->dev, &dev_attr_eeh_false_positives);
|
||||
rc += device_create_file(&pdev->dev, &dev_attr_eeh_freeze_count);
|
||||
|
||||
if (rc)
|
||||
|
@ -79,6 +81,7 @@ void eeh_sysfs_remove_device(struct pci_dev *pdev)
|
|||
device_remove_file(&pdev->dev, &dev_attr_eeh_config_addr);
|
||||
device_remove_file(&pdev->dev, &dev_attr_eeh_pe_config_addr);
|
||||
device_remove_file(&pdev->dev, &dev_attr_eeh_check_count);
|
||||
device_remove_file(&pdev->dev, &dev_attr_eeh_false_positives);
|
||||
device_remove_file(&pdev->dev, &dev_attr_eeh_freeze_count);
|
||||
}
|
||||
|
||||
|
|
|
@ -83,6 +83,7 @@ struct pci_dn {
|
|||
int eeh_pe_config_addr; /* new-style partition endpoint address */
|
||||
int eeh_check_count; /* # times driver ignored error */
|
||||
int eeh_freeze_count; /* # times this device froze up. */
|
||||
int eeh_false_positives; /* # times this device reported #ff's */
|
||||
u32 config_space[16]; /* saved PCI config space */
|
||||
#endif
|
||||
};
|
||||
|
|
Loading…
Reference in New Issue