UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: greybus: audio: Avoid less than zero check for le32 variable 

mixer control->info call back function checks for -ve values to rebase
min and max values. However, le32 variable is used to fetch values from
GB module FW. Thus negative value checking is not required. Fix this!!

Signed-off-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Acked-by: Mark Greer <mgreer@animalcreek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Vaibhav Agarwal 2017-01-18 22:51:50 +05:30 committed by Greg Kroah-Hartman
parent e965af6bb9
commit 84510052d6
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/greybus/audio_topology.c
View File

@ -371,12 +371,8 @@ static int gbcodec_mixer_dapm_ctl_info(struct snd_kcontrol *kcontrol,
uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
uinfo->count = data->vcount;
uinfo->value.integer.min = 0;
if (info->value.integer.min < 0 &&
(uinfo->type == SNDRV_CTL_ELEM_TYPE_INTEGER))
uinfo->value.integer.max = platform_max - platform_min;
else
uinfo->value.integer.max = platform_max;
uinfo->value.integer.min = platform_min;
uinfo->value.integer.max = platform_max;
return 0;
}