UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

V4L/DVB (7608): em28xx-dvb: Some cleanups and fixes 

em28xx-dvb.c:
 - Remove unneeded xc3028_ctrl structure.  The driver automatically preserves
   the previous value

tuner-xc2028.c:
 - Make the return type for xc2028_get_reg signed, since all of the callers
   are looking for "< 0" to detect errors.

Signed-off-by: Devin Heitmueller <devin.heitmueller@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
This commit is contained in:
Devin Heitmueller 2008-04-17 21:41:16 -03:00 committed by Mauro Carvalho Chehab
parent 6ea54d938b
commit 83244025e7
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/video/em28xx/em28xx-dvb.c
View File

@ -214,17 +214,13 @@ static struct zl10353_config em28xx_zl10353_with_xc3028 = {
static int attach_xc3028(u8 addr, struct em28xx *dev) static int attach_xc3028(u8 addr, struct em28xx *dev)
{ {
struct dvb_frontend *fe; struct dvb_frontend *fe;
struct xc2028_ctrl ctl;
struct xc2028_config cfg; struct xc2028_config cfg;
memset(&cfg, 0, sizeof(cfg)); memset(&cfg, 0, sizeof(cfg));
cfg.i2c_adap = &dev->i2c_adap; cfg.i2c_adap = &dev->i2c_adap;
cfg.i2c_addr = addr; cfg.i2c_addr = addr;
cfg.ctrl = &ctl;
cfg.callback = em28xx_tuner_callback; cfg.callback = em28xx_tuner_callback;
em28xx_setup_xc3028(dev, &ctl);
if (!dev->dvb->frontend) { if (!dev->dvb->frontend) {
printk(KERN_ERR "%s/2: dvb frontend not attached. " printk(KERN_ERR "%s/2: dvb frontend not attached. "
"Can't attach xc3028\n", "Can't attach xc3028\n",

2
drivers/media/video/tuner-xc2028.c
View File

@ -130,7 +130,7 @@ struct xc2028_data {
_rc; \ _rc; \
}) })
static unsigned int xc2028_get_reg(struct xc2028_data *priv, u16 reg, u16 *val) static int xc2028_get_reg(struct xc2028_data *priv, u16 reg, u16 *val)
{ {
unsigned char buf[2]; unsigned char buf[2];
unsigned char ibuf[2]; unsigned char ibuf[2];