From 826a4c6574efafdcfc292cdaf4dd2ccd6133d5f0 Mon Sep 17 00:00:00 2001 From: Sudip Mukherjee Date: Thu, 10 Nov 2016 22:12:01 +0000 Subject: [PATCH] ppdev: use pr_* macros The coding style recommends not to use printk. Use pr_* macros. Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman --- drivers/char/ppdev.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c index f08f3ed98e01..85c63e49df7f 100644 --- a/drivers/char/ppdev.c +++ b/drivers/char/ppdev.c @@ -294,7 +294,7 @@ static int register_device(int minor, struct pp_struct *pp) port = parport_find_number(minor); if (!port) { - printk(KERN_WARNING "%s: no associated port!\n", name); + pr_warn("%s: no associated port!\n", name); kfree(name); return -ENXIO; } @@ -308,7 +308,7 @@ static int register_device(int minor, struct pp_struct *pp) kfree(name); if (!pdev) { - printk(KERN_WARNING "%s: failed to register device!\n", name); + pr_warn("%s: failed to register device!\n", name); return -ENXIO; } @@ -822,8 +822,7 @@ static int __init ppdev_init(void) int err = 0; if (register_chrdev(PP_MAJOR, CHRDEV, &pp_fops)) { - printk(KERN_WARNING CHRDEV ": unable to get major %d\n", - PP_MAJOR); + pr_warn(CHRDEV ": unable to get major %d\n", PP_MAJOR); return -EIO; } ppdev_class = class_create(THIS_MODULE, CHRDEV); @@ -833,11 +832,11 @@ static int __init ppdev_init(void) } err = parport_register_driver(&pp_driver); if (err < 0) { - printk(KERN_WARNING CHRDEV ": unable to register with parport\n"); + pr_warn(CHRDEV ": unable to register with parport\n"); goto out_class; } - printk(KERN_INFO PP_VERSION "\n"); + pr_info(PP_VERSION "\n"); goto out; out_class: