ucsi_ccg: Check DEV_INT bit only when starting CCG4
CCGx clears Bit 0:Device Interrupt in the INTR_REG
if CCGx is reset successfully. However, there might
be a chance that other bits in INTR_REG are not
cleared due to internal data queued in PPM. This case
misleads the driver that CCGx reset failed.
The commit checks bit 0 in INTR_REG and ignores other
bits. The ucsi driver would reset PPM later.
Fixes: 247c554a14
("usb: typec: ucsi: add support for Cypress CCGx")
Cc: stable@vger.kernel.org
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Sing-Han Chen <singhanc@nvidia.com>
Signed-off-by: Wayne Chang <waynec@nvidia.com>
Link: https://lore.kernel.org/r/20220112094143.628610-1-waynec@nvidia.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
26fbe9772b
commit
825911492e
|
@ -325,7 +325,7 @@ static int ucsi_ccg_init(struct ucsi_ccg *uc)
|
|||
if (status < 0)
|
||||
return status;
|
||||
|
||||
if (!data)
|
||||
if (!(data & DEV_INT))
|
||||
return 0;
|
||||
|
||||
status = ccg_write(uc, CCGX_RAB_INTR_REG, &data, sizeof(data));
|
||||
|
|
Loading…
Reference in New Issue