UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

sfc/siena: Use the bitmap API to allocate bitmaps 

Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
Link: https://lore.kernel.org/r/717ba530215f4d7ce9fedcc73d98dba1f70d7f71.1657049636.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Christophe JAILLET 2022-07-05 21:34:08 +02:00 committed by Jakub Kicinski
parent 6ca4b39321
commit 820aceb53c
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/sfc/siena/farch.c
View File

@ -2778,7 +2778,7 @@ void efx_farch_filter_table_remove(struct efx_nic *efx)
enum efx_farch_filter_table_id table_id; enum efx_farch_filter_table_id table_id;
for (table_id = 0; table_id < EFX_FARCH_FILTER_TABLE_COUNT; table_id++) { for (table_id = 0; table_id < EFX_FARCH_FILTER_TABLE_COUNT; table_id++) {
kfree(state->table[table_id].used_bitmap); bitmap_free(state->table[table_id].used_bitmap);
vfree(state->table[table_id].spec); vfree(state->table[table_id].spec);
} }
kfree(state); kfree(state);
@ -2822,9 +2822,7 @@ int efx_farch_filter_table_probe(struct efx_nic *efx)
table = &state->table[table_id]; table = &state->table[table_id];
if (table->size == 0) if (table->size == 0)
continue; continue;
table->used_bitmap = kcalloc(BITS_TO_LONGS(table->size), table->used_bitmap = bitmap_zalloc(table->size, GFP_KERNEL);
sizeof(unsigned long),
GFP_KERNEL);
if (!table->used_bitmap) if (!table->used_bitmap)
goto fail; goto fail;
table->spec = vzalloc(array_size(sizeof(*table->spec), table->spec = vzalloc(array_size(sizeof(*table->spec),