From 813e34adeefbd4a8ee0d3003db79f1a3b97dfe17 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Fri, 21 Jun 2019 15:13:14 +0200 Subject: [PATCH] jz4740_fb: fix DMA API abuse Virtual addresses return from dma(m)_alloc_coherent are opaque in what backs then, and drivers must not poke into them. Signed-off-by: Christoph Hellwig Cc: Manuel Lauss [b.zolnierkie: patch description fixup] Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/jz4740_fb.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/video/fbdev/jz4740_fb.c b/drivers/video/fbdev/jz4740_fb.c index 145095655cc2..1f78b2bfe566 100644 --- a/drivers/video/fbdev/jz4740_fb.c +++ b/drivers/video/fbdev/jz4740_fb.c @@ -457,7 +457,6 @@ static int jzfb_alloc_devmem(struct jzfb *jzfb) { int max_videosize = 0; struct fb_videomode *mode = jzfb->pdata->modes; - void *page; int i; for (i = 0; i < jzfb->pdata->num_modes; ++mode, ++i) { @@ -482,12 +481,6 @@ static int jzfb_alloc_devmem(struct jzfb *jzfb) if (!jzfb->vidmem) goto err_free_framedesc; - for (page = jzfb->vidmem; - page < jzfb->vidmem + PAGE_ALIGN(jzfb->vidmem_size); - page += PAGE_SIZE) { - SetPageReserved(virt_to_page(page)); - } - jzfb->framedesc->next = jzfb->framedesc_phys; jzfb->framedesc->addr = jzfb->vidmem_phys; jzfb->framedesc->id = 0xdeafbead;