UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

rpmsg: qcom_smd: Make qcom_smd_unregister_edge() return void 

This function returned zero unconditionally. Convert it to return no
value instead. This makes it more obvious what happens in the callers.

One caller is converted to return zero explicitly. The only other caller
(smd_subdev_stop() in drivers/remoteproc/qcom_common.c) already ignored
the return value before.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230321154039.355098-2-u.kleine-koenig@pengutronix.de
This commit is contained in:
Uwe Kleine-König 2023-03-21 16:40:37 +01:00 committed by Bjorn Andersson
parent fe15c26ee2
commit 810c03d9d7
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/rpmsg/qcom_smd.c
View File

@ -1533,7 +1533,7 @@ static int qcom_smd_remove_device(struct device *dev, void *data)
* qcom_smd_unregister_edge() - release an edge and its children
* @edge: edge reference acquired from qcom_smd_register_edge
*/
int qcom_smd_unregister_edge(struct qcom_smd_edge *edge)
void qcom_smd_unregister_edge(struct qcom_smd_edge *edge)
{
int ret;
@ -1547,8 +1547,6 @@ int qcom_smd_unregister_edge(struct qcom_smd_edge *edge)
mbox_free_channel(edge->mbox_chan);
device_unregister(&edge->dev);
return 0;
}
EXPORT_SYMBOL(qcom_smd_unregister_edge);
@ -1572,7 +1570,9 @@ static int qcom_smd_remove_edge(struct device *dev, void *data)
{
struct qcom_smd_edge *edge = to_smd_edge(dev);
return qcom_smd_unregister_edge(edge);
qcom_smd_unregister_edge(edge);
return 0;
}
/*

5
include/linux/rpmsg/qcom_smd.h
View File

@ -11,7 +11,7 @@ struct qcom_smd_edge;
struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent,
struct device_node *node);
int qcom_smd_unregister_edge(struct qcom_smd_edge *edge);
void qcom_smd_unregister_edge(struct qcom_smd_edge *edge);
#else
@ -22,9 +22,8 @@ qcom_smd_register_edge(struct device *parent,
return NULL;
}
static inline int qcom_smd_unregister_edge(struct qcom_smd_edge *edge)
static inline void qcom_smd_unregister_edge(struct qcom_smd_edge *edge)
{
return 0;
}
#endif