RDMA/rtrs: Remove len parameter from helper print functions of sysfs
Since we have changed all sysfs show functions to use sysfs_emit, we do not require the len (PAGE_SIZE) in our helper print functions. So remove it from the function parameter. Link: https://lore.kernel.org/r/20210922125333.351454-3-haris.iqbal@ionos.com Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com> Signed-off-by: Jack Wang <jinpu.wang@ionos.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
This commit is contained in:
parent
2f232912fe
commit
80ad07f7e2
|
@ -37,8 +37,7 @@ void rtrs_clt_inc_failover_cnt(struct rtrs_clt_stats *stats)
|
||||||
s->rdma.failover_cnt++;
|
s->rdma.failover_cnt++;
|
||||||
}
|
}
|
||||||
|
|
||||||
int rtrs_clt_stats_migration_cnt_to_str(struct rtrs_clt_stats *stats,
|
int rtrs_clt_stats_migration_cnt_to_str(struct rtrs_clt_stats *stats, char *buf)
|
||||||
char *buf, size_t len)
|
|
||||||
{
|
{
|
||||||
struct rtrs_clt_stats_pcpu *s;
|
struct rtrs_clt_stats_pcpu *s;
|
||||||
|
|
||||||
|
@ -66,15 +65,13 @@ int rtrs_clt_stats_migration_cnt_to_str(struct rtrs_clt_stats *stats,
|
||||||
return used;
|
return used;
|
||||||
}
|
}
|
||||||
|
|
||||||
int rtrs_clt_stats_reconnects_to_str(struct rtrs_clt_stats *stats, char *buf,
|
int rtrs_clt_stats_reconnects_to_str(struct rtrs_clt_stats *stats, char *buf)
|
||||||
size_t len)
|
|
||||||
{
|
{
|
||||||
return sysfs_emit(buf, "%d %d\n", stats->reconnects.successful_cnt,
|
return sysfs_emit(buf, "%d %d\n", stats->reconnects.successful_cnt,
|
||||||
stats->reconnects.fail_cnt);
|
stats->reconnects.fail_cnt);
|
||||||
}
|
}
|
||||||
|
|
||||||
ssize_t rtrs_clt_stats_rdma_to_str(struct rtrs_clt_stats *stats,
|
ssize_t rtrs_clt_stats_rdma_to_str(struct rtrs_clt_stats *stats, char *page)
|
||||||
char *page, size_t len)
|
|
||||||
{
|
{
|
||||||
struct rtrs_clt_stats_rdma sum;
|
struct rtrs_clt_stats_rdma sum;
|
||||||
struct rtrs_clt_stats_rdma *r;
|
struct rtrs_clt_stats_rdma *r;
|
||||||
|
@ -98,8 +95,7 @@ ssize_t rtrs_clt_stats_rdma_to_str(struct rtrs_clt_stats *stats,
|
||||||
atomic_read(&stats->inflight), sum.failover_cnt);
|
atomic_read(&stats->inflight), sum.failover_cnt);
|
||||||
}
|
}
|
||||||
|
|
||||||
ssize_t rtrs_clt_reset_all_help(struct rtrs_clt_stats *s,
|
ssize_t rtrs_clt_reset_all_help(struct rtrs_clt_stats *s, char *page)
|
||||||
char *page, size_t len)
|
|
||||||
{
|
{
|
||||||
return sysfs_emit(page, "echo 1 to reset all statistics\n");
|
return sysfs_emit(page, "echo 1 to reset all statistics\n");
|
||||||
}
|
}
|
||||||
|
|
|
@ -224,19 +224,17 @@ void rtrs_clt_update_all_stats(struct rtrs_clt_io_req *req, int dir);
|
||||||
int rtrs_clt_reset_rdma_lat_distr_stats(struct rtrs_clt_stats *stats,
|
int rtrs_clt_reset_rdma_lat_distr_stats(struct rtrs_clt_stats *stats,
|
||||||
bool enable);
|
bool enable);
|
||||||
ssize_t rtrs_clt_stats_rdma_lat_distr_to_str(struct rtrs_clt_stats *stats,
|
ssize_t rtrs_clt_stats_rdma_lat_distr_to_str(struct rtrs_clt_stats *stats,
|
||||||
char *page, size_t len);
|
char *page);
|
||||||
int rtrs_clt_reset_cpu_migr_stats(struct rtrs_clt_stats *stats, bool enable);
|
int rtrs_clt_reset_cpu_migr_stats(struct rtrs_clt_stats *stats, bool enable);
|
||||||
int rtrs_clt_stats_migration_cnt_to_str(struct rtrs_clt_stats *stats, char *buf,
|
int rtrs_clt_stats_migration_cnt_to_str(struct rtrs_clt_stats *stats, char *buf);
|
||||||
size_t len);
|
|
||||||
int rtrs_clt_reset_reconnects_stat(struct rtrs_clt_stats *stats, bool enable);
|
int rtrs_clt_reset_reconnects_stat(struct rtrs_clt_stats *stats, bool enable);
|
||||||
int rtrs_clt_stats_reconnects_to_str(struct rtrs_clt_stats *stats, char *buf,
|
int rtrs_clt_stats_reconnects_to_str(struct rtrs_clt_stats *stats, char *buf);
|
||||||
size_t len);
|
|
||||||
int rtrs_clt_reset_rdma_stats(struct rtrs_clt_stats *stats, bool enable);
|
int rtrs_clt_reset_rdma_stats(struct rtrs_clt_stats *stats, bool enable);
|
||||||
ssize_t rtrs_clt_stats_rdma_to_str(struct rtrs_clt_stats *stats,
|
ssize_t rtrs_clt_stats_rdma_to_str(struct rtrs_clt_stats *stats,
|
||||||
char *page, size_t len);
|
char *page);
|
||||||
int rtrs_clt_reset_all_stats(struct rtrs_clt_stats *stats, bool enable);
|
int rtrs_clt_reset_all_stats(struct rtrs_clt_stats *stats, bool enable);
|
||||||
ssize_t rtrs_clt_reset_all_help(struct rtrs_clt_stats *stats,
|
ssize_t rtrs_clt_reset_all_help(struct rtrs_clt_stats *stats,
|
||||||
char *page, size_t len);
|
char *page);
|
||||||
|
|
||||||
/* rtrs-clt-sysfs.c */
|
/* rtrs-clt-sysfs.c */
|
||||||
|
|
||||||
|
|
|
@ -398,7 +398,7 @@ static ssize_t get_value##_show(struct kobject *kobj, \
|
||||||
{ \
|
{ \
|
||||||
type *stats = container_of(kobj, type, kobj_stats); \
|
type *stats = container_of(kobj, type, kobj_stats); \
|
||||||
\
|
\
|
||||||
return print(stats, page, PAGE_SIZE); \
|
return print(stats, page); \
|
||||||
}
|
}
|
||||||
|
|
||||||
#define STAT_ATTR(type, stat, print, reset) \
|
#define STAT_ATTR(type, stat, print, reset) \
|
||||||
|
|
|
@ -23,8 +23,7 @@ int rtrs_srv_reset_rdma_stats(struct rtrs_srv_stats *stats, bool enable)
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
ssize_t rtrs_srv_stats_rdma_to_str(struct rtrs_srv_stats *stats,
|
ssize_t rtrs_srv_stats_rdma_to_str(struct rtrs_srv_stats *stats, char *page)
|
||||||
char *page, size_t len)
|
|
||||||
{
|
{
|
||||||
struct rtrs_srv_stats_rdma_stats *r = &stats->rdma_stats;
|
struct rtrs_srv_stats_rdma_stats *r = &stats->rdma_stats;
|
||||||
|
|
||||||
|
|
|
@ -136,8 +136,7 @@ static inline void rtrs_srv_update_rdma_stats(struct rtrs_srv_stats *s,
|
||||||
|
|
||||||
/* functions which are implemented in rtrs-srv-stats.c */
|
/* functions which are implemented in rtrs-srv-stats.c */
|
||||||
int rtrs_srv_reset_rdma_stats(struct rtrs_srv_stats *stats, bool enable);
|
int rtrs_srv_reset_rdma_stats(struct rtrs_srv_stats *stats, bool enable);
|
||||||
ssize_t rtrs_srv_stats_rdma_to_str(struct rtrs_srv_stats *stats,
|
ssize_t rtrs_srv_stats_rdma_to_str(struct rtrs_srv_stats *stats, char *page);
|
||||||
char *page, size_t len);
|
|
||||||
int rtrs_srv_reset_all_stats(struct rtrs_srv_stats *stats, bool enable);
|
int rtrs_srv_reset_all_stats(struct rtrs_srv_stats *stats, bool enable);
|
||||||
ssize_t rtrs_srv_reset_all_help(struct rtrs_srv_stats *stats,
|
ssize_t rtrs_srv_reset_all_help(struct rtrs_srv_stats *stats,
|
||||||
char *page, size_t len);
|
char *page, size_t len);
|
||||||
|
|
Loading…
Reference in New Issue