mic: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> Cc: linux-kernel@vger.kernel.org Reviewed-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Sudeep Dutt <sudeep.dutt@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
053cf51040
commit
7e9f02a789
|
@ -63,25 +63,13 @@ DEFINE_SHOW_ATTRIBUTE(mic_intr);
|
||||||
*/
|
*/
|
||||||
void __init mic_create_card_debug_dir(struct mic_driver *mdrv)
|
void __init mic_create_card_debug_dir(struct mic_driver *mdrv)
|
||||||
{
|
{
|
||||||
struct dentry *d;
|
|
||||||
|
|
||||||
if (!mic_dbg)
|
if (!mic_dbg)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
mdrv->dbg_dir = debugfs_create_dir(mdrv->name, mic_dbg);
|
mdrv->dbg_dir = debugfs_create_dir(mdrv->name, mic_dbg);
|
||||||
if (!mdrv->dbg_dir) {
|
|
||||||
dev_err(mdrv->dev, "Cant create dbg_dir %s\n", mdrv->name);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
d = debugfs_create_file("intr_test", 0444, mdrv->dbg_dir,
|
debugfs_create_file("intr_test", 0444, mdrv->dbg_dir, mdrv,
|
||||||
mdrv, &mic_intr_fops);
|
&mic_intr_fops);
|
||||||
|
|
||||||
if (!d) {
|
|
||||||
dev_err(mdrv->dev,
|
|
||||||
"Cant create dbg intr_test %s\n", mdrv->name);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -101,8 +89,6 @@ void mic_delete_card_debug_dir(struct mic_driver *mdrv)
|
||||||
void __init mic_init_card_debugfs(void)
|
void __init mic_init_card_debugfs(void)
|
||||||
{
|
{
|
||||||
mic_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL);
|
mic_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL);
|
||||||
if (!mic_dbg)
|
|
||||||
pr_err("can't create debugfs dir\n");
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
|
@ -105,8 +105,6 @@ void cosm_create_debug_dir(struct cosm_device *cdev)
|
||||||
|
|
||||||
scnprintf(name, sizeof(name), "mic%d", cdev->index);
|
scnprintf(name, sizeof(name), "mic%d", cdev->index);
|
||||||
cdev->dbg_dir = debugfs_create_dir(name, cosm_dbg);
|
cdev->dbg_dir = debugfs_create_dir(name, cosm_dbg);
|
||||||
if (!cdev->dbg_dir)
|
|
||||||
return;
|
|
||||||
|
|
||||||
debugfs_create_file("log_buf", 0444, cdev->dbg_dir, cdev,
|
debugfs_create_file("log_buf", 0444, cdev->dbg_dir, cdev,
|
||||||
&log_buf_fops);
|
&log_buf_fops);
|
||||||
|
@ -125,8 +123,6 @@ void cosm_delete_debug_dir(struct cosm_device *cdev)
|
||||||
void cosm_init_debugfs(void)
|
void cosm_init_debugfs(void)
|
||||||
{
|
{
|
||||||
cosm_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL);
|
cosm_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL);
|
||||||
if (!cosm_dbg)
|
|
||||||
pr_err("can't create debugfs dir\n");
|
|
||||||
}
|
}
|
||||||
|
|
||||||
void cosm_exit_debugfs(void)
|
void cosm_exit_debugfs(void)
|
||||||
|
|
|
@ -125,8 +125,6 @@ void mic_create_debug_dir(struct mic_device *mdev)
|
||||||
|
|
||||||
scnprintf(name, sizeof(name), "mic%d", mdev->id);
|
scnprintf(name, sizeof(name), "mic%d", mdev->id);
|
||||||
mdev->dbg_dir = debugfs_create_dir(name, mic_dbg);
|
mdev->dbg_dir = debugfs_create_dir(name, mic_dbg);
|
||||||
if (!mdev->dbg_dir)
|
|
||||||
return;
|
|
||||||
|
|
||||||
debugfs_create_file("smpt", 0444, mdev->dbg_dir, mdev,
|
debugfs_create_file("smpt", 0444, mdev->dbg_dir, mdev,
|
||||||
&mic_smpt_fops);
|
&mic_smpt_fops);
|
||||||
|
@ -155,8 +153,6 @@ void mic_delete_debug_dir(struct mic_device *mdev)
|
||||||
void __init mic_init_debugfs(void)
|
void __init mic_init_debugfs(void)
|
||||||
{
|
{
|
||||||
mic_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL);
|
mic_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL);
|
||||||
if (!mic_dbg)
|
|
||||||
pr_err("can't create debugfs dir\n");
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
|
@ -103,11 +103,6 @@ DEFINE_SHOW_ATTRIBUTE(scif_rma);
|
||||||
void __init scif_init_debugfs(void)
|
void __init scif_init_debugfs(void)
|
||||||
{
|
{
|
||||||
scif_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL);
|
scif_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL);
|
||||||
if (!scif_dbg) {
|
|
||||||
dev_err(scif_info.mdev.this_device,
|
|
||||||
"can't create debugfs dir scif\n");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
debugfs_create_file("scif_dev", 0444, scif_dbg, NULL, &scif_dev_fops);
|
debugfs_create_file("scif_dev", 0444, scif_dbg, NULL, &scif_dev_fops);
|
||||||
debugfs_create_file("scif_rma", 0444, scif_dbg, NULL, &scif_rma_fops);
|
debugfs_create_file("scif_rma", 0444, scif_dbg, NULL, &scif_rma_fops);
|
||||||
|
|
|
@ -186,10 +186,6 @@ void vop_init_debugfs(struct vop_info *vi)
|
||||||
|
|
||||||
snprintf(name, sizeof(name), "%s%d", KBUILD_MODNAME, vi->vpdev->dnode);
|
snprintf(name, sizeof(name), "%s%d", KBUILD_MODNAME, vi->vpdev->dnode);
|
||||||
vi->dbg = debugfs_create_dir(name, NULL);
|
vi->dbg = debugfs_create_dir(name, NULL);
|
||||||
if (!vi->dbg) {
|
|
||||||
pr_err("can't create debugfs dir vop\n");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
debugfs_create_file("dp", 0444, vi->dbg, vi, &vop_dp_fops);
|
debugfs_create_file("dp", 0444, vi->dbg, vi, &vop_dp_fops);
|
||||||
debugfs_create_file("vdev_info", 0444, vi->dbg, vi, &vop_vdev_info_fops);
|
debugfs_create_file("vdev_info", 0444, vi->dbg, vi, &vop_vdev_info_fops);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue