drm/i915: Reject non-default contexts on non-render again
This reverts the abi-change from
commit 67e3d2979b
Author: Ben Widawsky <ben@bwidawsk.net>
Date: Fri Dec 6 14:11:01 2013 -0800
drm/i915: Permit contexts on all rings
We don't actually need this, only the internal changes to allow
contexts on all rings for the purpose of ppgtt switching are required.
And I'm not sure whether this is the right thing to do given some of
the hw features in the pipeline.
Also, new abi needs userspace patches as a proof-of-need, which is
completely lacking here.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
parent
7d9c477966
commit
7c9c4b8f5d
|
@ -890,11 +890,14 @@ validate_exec_list(struct drm_i915_gem_exec_object2 *exec,
|
||||||
|
|
||||||
static struct i915_hw_context *
|
static struct i915_hw_context *
|
||||||
i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
|
i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
|
||||||
const u32 ctx_id)
|
struct intel_ring_buffer *ring, const u32 ctx_id)
|
||||||
{
|
{
|
||||||
struct i915_hw_context *ctx = NULL;
|
struct i915_hw_context *ctx = NULL;
|
||||||
struct i915_ctx_hang_stats *hs;
|
struct i915_ctx_hang_stats *hs;
|
||||||
|
|
||||||
|
if (ring->id != RCS && ctx_id != DEFAULT_CONTEXT_ID)
|
||||||
|
return ERR_PTR(-EINVAL);
|
||||||
|
|
||||||
ctx = i915_gem_context_get(file->driver_priv, ctx_id);
|
ctx = i915_gem_context_get(file->driver_priv, ctx_id);
|
||||||
if (IS_ERR_OR_NULL(ctx))
|
if (IS_ERR_OR_NULL(ctx))
|
||||||
return ctx;
|
return ctx;
|
||||||
|
@ -1103,7 +1106,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
|
||||||
goto pre_mutex_err;
|
goto pre_mutex_err;
|
||||||
}
|
}
|
||||||
|
|
||||||
ctx = i915_gem_validate_context(dev, file, ctx_id);
|
ctx = i915_gem_validate_context(dev, file, ring, ctx_id);
|
||||||
if (IS_ERR_OR_NULL(ctx)) {
|
if (IS_ERR_OR_NULL(ctx)) {
|
||||||
mutex_unlock(&dev->struct_mutex);
|
mutex_unlock(&dev->struct_mutex);
|
||||||
ret = PTR_ERR(ctx);
|
ret = PTR_ERR(ctx);
|
||||||
|
|
Loading…
Reference in New Issue