UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

ASoC: qcom: sm8250: Fix array out of bounds access 

Static analysis Coverity had detected a potential array out-of-bounds
write issue due to the fact that MAX AFE port Id was set to 16 instead
of using AFE_PORT_MAX macro.

Fix this by properly using AFE_PORT_MAX macro.

Fixes: aa2e278554 ("ASoC: qcom: sm8250: add sound card qrb5165-rb5 support")
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20201028142001.22431-1-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Srinivas Kandagatla 2020-10-28 14:20:01 +00:00 committed by Mark Brown
parent e4c164d638
commit 7c91d02068
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sound/soc/qcom/sm8250.c
View File

@ -13,12 +13,11 @@
#define DRIVER_NAME "sm8250" #define DRIVER_NAME "sm8250"
#define MI2S_BCLK_RATE 1536000 #define MI2S_BCLK_RATE 1536000
#define MAX_SDW_STREAMS 16
struct sm8250_snd_data { struct sm8250_snd_data {
bool stream_prepared[MAX_SDW_STREAMS]; bool stream_prepared[AFE_PORT_MAX];
struct snd_soc_card *card; struct snd_soc_card *card;
struct sdw_stream_runtime *sruntime[MAX_SDW_STREAMS]; struct sdw_stream_runtime *sruntime[AFE_PORT_MAX];
}; };
static int sm8250_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd, static int sm8250_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,