UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

ath10k: remove unnecessary comparison of unsigned integer with < 0 

There is no need to compare *ps_state_enable* with < 0 because
such variable is of type u8 (8 bits, unsigned), making it
impossible to hold a negative value.

Fix this by removing such comparison.

Addresses-Coverity-ID: 1473921 ("Unsigned compared against 0")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Gustavo A. R. Silva 2018-10-05 20:56:23 +02:00 committed by Kalle Valo
parent 9d9cdbf3f9
commit 7bfd82bff6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wireless/ath/ath10k/debug.c
View File

@ -2421,7 +2421,7 @@ static ssize_t ath10k_write_ps_state_enable(struct file *file,
if (kstrtou8_from_user(user_buf, count, 0, &ps_state_enable)) if (kstrtou8_from_user(user_buf, count, 0, &ps_state_enable))
return -EINVAL; return -EINVAL;
if (ps_state_enable > 1 || ps_state_enable < 0) if (ps_state_enable > 1)
return -EINVAL; return -EINVAL;
mutex_lock(&ar->conf_mutex); mutex_lock(&ar->conf_mutex);