UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: broadcom: bcm4908_enet: drop "inline" from C functions 

It seems preferred to let compiler optimize code if applicable.
While at it drop unused enet_umac_maskset().

Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Rafał Miłecki 2021-02-11 13:12:36 +01:00 committed by David S. Miller
parent af263af646
commit 7b778ae4eb
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/net/ethernet/broadcom/bcm4908_enet.c
View File

@ -75,17 +75,17 @@ struct bcm4908_enet {
* R/W ops * R/W ops
*/ */
static inline u32 enet_read(struct bcm4908_enet *enet, u16 offset) static u32 enet_read(struct bcm4908_enet *enet, u16 offset)
{ {
return readl(enet->base + offset); return readl(enet->base + offset);
} }
static inline void enet_write(struct bcm4908_enet *enet, u16 offset, u32 value) static void enet_write(struct bcm4908_enet *enet, u16 offset, u32 value)
{ {
writel(value, enet->base + offset); writel(value, enet->base + offset);
} }
static inline void enet_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set) static void enet_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set)
{ {
u32 val; u32 val;
@ -96,27 +96,22 @@ static inline void enet_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask,
enet_write(enet, offset, val); enet_write(enet, offset, val);
} }
static inline void enet_set(struct bcm4908_enet *enet, u16 offset, u32 set) static void enet_set(struct bcm4908_enet *enet, u16 offset, u32 set)
{ {
enet_maskset(enet, offset, set, set); enet_maskset(enet, offset, set, set);
} }
static inline u32 enet_umac_read(struct bcm4908_enet *enet, u16 offset) static u32 enet_umac_read(struct bcm4908_enet *enet, u16 offset)
{ {
return enet_read(enet, ENET_UNIMAC + offset); return enet_read(enet, ENET_UNIMAC + offset);
} }
static inline void enet_umac_write(struct bcm4908_enet *enet, u16 offset, u32 value) static void enet_umac_write(struct bcm4908_enet *enet, u16 offset, u32 value)
{ {
enet_write(enet, ENET_UNIMAC + offset, value); enet_write(enet, ENET_UNIMAC + offset, value);
} }
static inline void enet_umac_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set) static void enet_umac_set(struct bcm4908_enet *enet, u16 offset, u32 set)
{
enet_maskset(enet, ENET_UNIMAC + offset, mask, set);
}
static inline void enet_umac_set(struct bcm4908_enet *enet, u16 offset, u32 set)
{ {
enet_set(enet, ENET_UNIMAC + offset, set); enet_set(enet, ENET_UNIMAC + offset, set);
} }