UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

vdpa: Fix error logic in vdpa_nl_cmd_dev_get_doit 

In vdpa_nl_cmd_dev_get_doit(), if the call to genlmsg_reply() fails we
must not call nlmsg_free() since this is done inside genlmsg_reply().

Fix it.

Fixes: bc0d90ee02 ("vdpa: Enable user to query vdpa device info")
Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Eli Cohen <elic@nvidia.com>
Message-Id: <20220518133804.1075129-2-elic@nvidia.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Eli Cohen 2022-05-18 16:37:59 +03:00 committed by Michael S. Tsirkin
parent 8ab2afa23b
commit 7a6691f1f8
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/vdpa/vdpa.c
View File

@ -756,14 +756,19 @@ static int vdpa_nl_cmd_dev_get_doit(struct sk_buff *skb, struct genl_info *info)
goto mdev_err; goto mdev_err;
} }
err = vdpa_dev_fill(vdev, msg, info->snd_portid, info->snd_seq, 0, info->extack); err = vdpa_dev_fill(vdev, msg, info->snd_portid, info->snd_seq, 0, info->extack);
if (!err) if (err)
err = genlmsg_reply(msg, info); goto mdev_err;
err = genlmsg_reply(msg, info);
put_device(dev);
mutex_unlock(&vdpa_dev_mutex);
return err;
mdev_err: mdev_err:
put_device(dev); put_device(dev);
err: err:
mutex_unlock(&vdpa_dev_mutex); mutex_unlock(&vdpa_dev_mutex);
if (err) nlmsg_free(msg);
nlmsg_free(msg);
return err; return err;
} }