UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

usb: typec: tipd: Fix spurious fwnode_handle_put in error path 

The err_role_put error path always calls fwnode_handle_put to release
the fwnode. This path can be reached after probe itself has already
released that fwnode though. Fix that by moving fwnode_handle_put in the
happy path to the very end.

Fixes: 18a6c866bb ("usb: typec: tps6598x: Add USB role switching logic")
Signed-off-by: Sven Peter <sven@svenpeter.dev>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20221114174449.34634-2-sven@svenpeter.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sven Peter 2022-11-14 18:44:47 +01:00 committed by Greg Kroah-Hartman
parent 19c220e9ab
commit 782c70edc4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/typec/tipd/core.c
View File

@ -821,7 +821,6 @@ static int tps6598x_probe(struct i2c_client *client)
ret = PTR_ERR(tps->port); ret = PTR_ERR(tps->port);
goto err_role_put; goto err_role_put;
} }
fwnode_handle_put(fwnode);
if (status & TPS_STATUS_PLUG_PRESENT) { if (status & TPS_STATUS_PLUG_PRESENT) {
ret = tps6598x_read16(tps, TPS_REG_POWER_STATUS, &tps->pwr_status); ret = tps6598x_read16(tps, TPS_REG_POWER_STATUS, &tps->pwr_status);
@ -845,6 +844,7 @@ static int tps6598x_probe(struct i2c_client *client)
} }
i2c_set_clientdata(client, tps); i2c_set_clientdata(client, tps);
fwnode_handle_put(fwnode);
return 0; return 0;