remoteproc: Use struct_size() helper
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct resource_table { ... u32 offset[0]; } __packed; Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. So, replace the following form: table->num * sizeof(table->offset[0]) + sizeof(struct resource_table) with: struct_size(table, offset, table->num) This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
This commit is contained in:
parent
b1a17513a2
commit
77e5a44879
|
@ -255,8 +255,7 @@ find_table(struct device *dev, struct elf32_hdr *ehdr, size_t fw_size)
|
||||||
}
|
}
|
||||||
|
|
||||||
/* make sure the offsets array isn't truncated */
|
/* make sure the offsets array isn't truncated */
|
||||||
if (table->num * sizeof(table->offset[0]) +
|
if (struct_size(table, offset, table->num) > size) {
|
||||||
sizeof(struct resource_table) > size) {
|
|
||||||
dev_err(dev, "resource table incomplete\n");
|
dev_err(dev, "resource table incomplete\n");
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue