drm/msm: Move submit bo flags update from obj lock
The flags are only accessed (1) when submit is constructed, before enqueuing to gpu sched (ie. when still visible to only the task calling the submit ioctl), (2) here, where we own a reference to the submit and are serialized on the gpu sched thread, and (3) after the submit is retired and last reference is dropped, which is serialized on the submit's reference count. Hence locking is unneeded here. Signed-off-by: Rob Clark <robdclark@chromium.org> Patchwork: https://patchwork.freedesktop.org/patch/527830/ Link: https://lore.kernel.org/r/20230320144356.803762-3-robdclark@gmail.com
This commit is contained in:
parent
f94e6a51e1
commit
769fec1e4f
|
@ -26,8 +26,8 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job)
|
|||
msm_gem_lock(obj);
|
||||
msm_gem_unpin_vma_fenced(submit->bos[i].vma, fctx);
|
||||
msm_gem_unpin_locked(obj);
|
||||
submit->bos[i].flags &= ~(BO_VMA_PINNED | BO_OBJ_PINNED);
|
||||
msm_gem_unlock(obj);
|
||||
submit->bos[i].flags &= ~(BO_VMA_PINNED | BO_OBJ_PINNED);
|
||||
}
|
||||
|
||||
/* TODO move submit path over to using a per-ring lock.. */
|
||||
|
|
Loading…
Reference in New Issue