platform/x86: intel_skl_int3472: Provide skl_int3472_unregister_clock()

For the sake of APIs to be properly layered provide
skl_int3472_unregister_clock().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Daniel Scally <djrscally@gmail.com>
Tested-by: Daniel Scally <djrscally@gmail.com>
Link: https://lore.kernel.org/r/20210618125516.53510-6-andriy.shevchenko@linux.intel.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Andy Shevchenko 2021-06-18 15:55:14 +03:00 committed by Hans de Goede
parent 7b2baa407c
commit 7540599a5e
3 changed files with 10 additions and 3 deletions

View File

@ -130,6 +130,12 @@ out_free_init_name:
return ret; return ret;
} }
void skl_int3472_unregister_clock(struct int3472_discrete_device *int3472)
{
clkdev_drop(int3472->clock.cl);
clk_unregister(int3472->clock.clk);
}
int skl_int3472_register_regulator(struct int3472_discrete_device *int3472, int skl_int3472_register_regulator(struct int3472_discrete_device *int3472,
struct acpi_resource_gpio *agpio) struct acpi_resource_gpio *agpio)
{ {

View File

@ -111,7 +111,9 @@ int skl_int3472_tps68470_probe(struct i2c_client *client);
union acpi_object *skl_int3472_get_acpi_buffer(struct acpi_device *adev, union acpi_object *skl_int3472_get_acpi_buffer(struct acpi_device *adev,
char *id); char *id);
int skl_int3472_fill_cldb(struct acpi_device *adev, struct int3472_cldb *cldb); int skl_int3472_fill_cldb(struct acpi_device *adev, struct int3472_cldb *cldb);
int skl_int3472_register_clock(struct int3472_discrete_device *int3472); int skl_int3472_register_clock(struct int3472_discrete_device *int3472);
void skl_int3472_unregister_clock(struct int3472_discrete_device *int3472);
int skl_int3472_register_regulator(struct int3472_discrete_device *int3472, int skl_int3472_register_regulator(struct int3472_discrete_device *int3472,
struct acpi_resource_gpio *agpio); struct acpi_resource_gpio *agpio);

View File

@ -400,10 +400,9 @@ int skl_int3472_discrete_remove(struct platform_device *pdev)
struct int3472_discrete_device *int3472 = platform_get_drvdata(pdev); struct int3472_discrete_device *int3472 = platform_get_drvdata(pdev);
gpiod_remove_lookup_table(&int3472->gpios); gpiod_remove_lookup_table(&int3472->gpios);
clk_unregister(int3472->clock.clk);
if (int3472->clock.cl) if (int3472->clock.ena_gpio)
clkdev_drop(int3472->clock.cl); skl_int3472_unregister_clock(int3472);
gpiod_put(int3472->clock.ena_gpio); gpiod_put(int3472->clock.ena_gpio);
gpiod_put(int3472->clock.led_gpio); gpiod_put(int3472->clock.led_gpio);