UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

net:nfc:digital: Fix a double free in digital_tg_recv_dep_req 

In digital_tg_recv_dep_req, it calls nfc_tm_data_received(..,resp).
If nfc_tm_data_received() failed, the callee will free the resp via
kfree_skb() and return error. But in the exit branch, the resp
will be freed again.

My patch sets resp to NULL if nfc_tm_data_received() failed, to
avoid the double free.

Fixes: 1c7a4c24fb ("NFC Digital: Add target NFC-DEP support")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Lv Yunlong 2021-04-27 09:22:58 -07:00 committed by David S. Miller
parent 0711459095
commit 7525858679
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/nfc/digital_dep.c
View File

@ -1273,6 +1273,8 @@ static void digital_tg_recv_dep_req(struct nfc_digital_dev *ddev, void *arg,
} }
rc = nfc_tm_data_received(ddev->nfc_dev, resp); rc = nfc_tm_data_received(ddev->nfc_dev, resp);
if (rc)
resp = NULL;
exit: exit:
kfree_skb(ddev->chaining_skb); kfree_skb(ddev->chaining_skb);